From fb1f5259bf84acb977befaf95f28cda1299fda7c Mon Sep 17 00:00:00 2001
From: Jeff Balogh <jbalogh@mozilla.com>
Date: Fri, 03 Sep 2010 20:09:14 +0000
Subject: UX fixes for spam page

---
diff --git a/apps/reviews/templates/reviews/spam.html b/apps/reviews/templates/reviews/spam.html
index 25cc4f7..2894f90 100644
--- a/apps/reviews/templates/reviews/spam.html
+++ b/apps/reviews/templates/reviews/spam.html
@@ -12,16 +12,26 @@
   ('numbers', 'Overwhelmingly Productive'),
 ) %}
 
+{% set trans = {
+  'urls': 'containing urls',
+  'numbers': 'creating too many reviews',
+  'matches': 'duplicate content',
+} %}
+
 {% for key, title in keys %}
   {% if buckets[key] %}
     <div>
       <h3>{{ title }}</h3>
       {% for review in buckets[key] %}
-        <form method="post" action="">
+        <form method="post" action="" style="margin-bottom: 2em">
           {{ csrf() }}
           {% with addon = review.addon %}
             {% include "reviews/review.html" %}
           {% endwith %}
+          <p style="margin-bottom: .4em">
+            For <a href="{{ review.addon.get_url_path() }}">{{ review.addon.name }}</a>
+            &mdash; flagged for {{ trans[key] }}.
+          </p>
           <input type="hidden" name="review" value="{{ review.id }}">
           <input type="hidden" name="addon" value="{{ review.addon_id }}">
           <input type="submit" name="del_user" value="Delete User">
diff --git a/apps/reviews/views.py b/apps/reviews/views.py
index 7907c81..340dca2 100644
--- a/apps/reviews/views.py
+++ b/apps/reviews/views.py
@@ -204,8 +204,11 @@ def spam(request):
     for reason in spam.reasons():
         ids = spam.redis.smembers(reason)
         key = reason.split(':')[-1]
-        buckets[key] = (Review.objects.no_cache().filter(id__in=ids)
-                        .select_related('addon'))
+        buckets[key] = Review.objects.no_cache().filter(id__in=ids)
+    reviews = dict((review.addon_id, review) for bucket in buckets.values()
+                                             for review in bucket)
+    for addon in Addon.objects.no_cache().filter(id__in=reviews):
+        reviews[addon.id].addon = addon
     return jingo.render(request, 'reviews/spam.html',
                         dict(buckets=buckets,
                              review_perms=dict(is_admin=True)))
--
cgit v0.9.1