diff options
| author | Carlos Garcia Campos <carlosgc@gnome.org> | 2008-02-27 17:32:52 (GMT) |
|---|---|---|
| committer | Carlos Garcia Campos <carlosgc@src.gnome.org> | 2008-02-27 17:32:52 (GMT) |
| commit | d1b42341039d4e26cf299c2fc50d36cd18760011 (patch) | |
| tree | c1f1c2f07576c524330750d0ada4a18a82e83597 | |
| parent | 1aa84014113a4c139d31e4da47616cd097fc7348 (diff) | |
Fix a crash when a choice form field doesn't have any item selected. Fixes
2008-02-27 Carlos Garcia Campos <carlosgc@gnome.org>
* shell/ev-view.c: (ev_view_form_field_choice_changed):
Fix a crash when a choice form field doesn't have any item
selected. Fixes bug #518831
svn path=/trunk/; revision=2930
| -rw-r--r-- | ChangeLog | 7 | ||||
| -rw-r--r-- | shell/ev-view.c | 3 |
2 files changed, 9 insertions, 1 deletions
@@ -1,3 +1,10 @@ +2008-02-27 Carlos Garcia Campos <carlosgc@gnome.org> + + * shell/ev-view.c: (ev_view_form_field_choice_changed): + + Fix a crash when a choice form field doesn't have any item + selected. Fixes bug #518831 + 2008-02-25 Alexander Larsson <alexl@redhat.com> * shell/ev-window.c (ev_window_clear_temp_file): diff --git a/shell/ev-view.c b/shell/ev-view.c index dc1d190..3b7a60d 100644 --- a/shell/ev-view.c +++ b/shell/ev-view.c @@ -1907,7 +1907,8 @@ ev_view_form_field_choice_changed (GtkWidget *widget, gint item; item = gtk_combo_box_get_active (GTK_COMBO_BOX (widget)); - if (GPOINTER_TO_INT (field_choice->selected_items->data) != item) { + if (!field_choice->selected_items || + GPOINTER_TO_INT (field_choice->selected_items->data) != item) { g_list_free (field_choice->selected_items); field_choice->selected_items = NULL; field_choice->selected_items = g_list_prepend (field_choice->selected_items, |