Web   ·   Wiki   ·   Activities   ·   Blog   ·   Lists   ·   Chat   ·   Meeting   ·   Bugs   ·   Git   ·   Translate   ·   Archive   ·   People   ·   Donate
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKristian Høgsberg <krh@redhat.com>2005-04-06 03:48:58 (GMT)
committer Kristian Høgsberg <krh@src.gnome.org>2005-04-06 03:48:58 (GMT)
commit8e19cbbce0b1860b2fdb5bb4453fc30601bea96b (patch)
tree64b7a2a35cdf45b563f8c61032e293b0bed6cf1a
parent7c45d10b8cc2fa9668cf7a07cc3924ac39060ac3 (diff)
Fix of by one errors.
2005-04-05 Kristian Høgsberg <krh@redhat.com> * backend/ev-page-cache.c (ev_page_cache_next_page): * shell/ev-window.c (ev_window_cmd_go_next_page) (ev_window_cmd_go_first_page): Fix of by one errors.
-rw-r--r--ChangeLog6
-rw-r--r--backend/ev-page-cache.c2
-rw-r--r--shell/ev-window.c4
3 files changed, 9 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index 3ca29d8..8d83d0c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2005-04-05 Kristian Høgsberg <krh@redhat.com>
+
+ * backend/ev-page-cache.c (ev_page_cache_next_page):
+ * shell/ev-window.c (ev_window_cmd_go_next_page)
+ (ev_window_cmd_go_first_page): Fix of by one errors.
+
2005-04-05 Marco Pesenti Gritti <mpg@redhat.com>
* ps/ps-document.c: (get_page_box):
diff --git a/backend/ev-page-cache.c b/backend/ev-page-cache.c
index 7960cb4..7f6622a 100644
--- a/backend/ev-page-cache.c
+++ b/backend/ev-page-cache.c
@@ -290,7 +290,7 @@ ev_page_cache_next_page (EvPageCache *page_cache)
{
g_return_val_if_fail (EV_IS_PAGE_CACHE (page_cache), FALSE);
- if (page_cache->current_page > page_cache->n_pages)
+ if (page_cache->current_page >= page_cache->n_pages)
return FALSE;
ev_page_cache_set_current_page (page_cache, page_cache->current_page + 1);
diff --git a/shell/ev-window.c b/shell/ev-window.c
index 64b072e..92e68f4 100644
--- a/shell/ev-window.c
+++ b/shell/ev-window.c
@@ -1491,7 +1491,7 @@ ev_window_cmd_go_first_page (GtkAction *action, EvWindow *ev_window)
{
g_return_if_fail (EV_IS_WINDOW (ev_window));
- ev_page_cache_set_current_page (ev_window->priv->page_cache, 1);
+ ev_page_cache_set_current_page (ev_window->priv->page_cache, 0);
}
static void
@@ -1502,7 +1502,7 @@ ev_window_cmd_go_last_page (GtkAction *action, EvWindow *ev_window)
g_return_if_fail (EV_IS_WINDOW (ev_window));
n_pages = ev_page_cache_get_n_pages (ev_window->priv->page_cache);
- ev_page_cache_set_current_page (ev_window->priv->page_cache, n_pages);
+ ev_page_cache_set_current_page (ev_window->priv->page_cache, n_pages - 1);
}
static void