From f302b9a420aaf02e5805b3225ce4fef5a63e9b67 Mon Sep 17 00:00:00 2001 From: Nickolay V. Shmyrev Date: Sat, 18 Jun 2005 19:22:00 +0000 Subject: Fixed lot's of memory leaks, for example, memory leak on reload, described * shell/ev-page-action.c: (match_selected_cb), (display_completion_text), (match_completion), (update_model): * shell/ev-sidebar-links.c: (ev_sidebar_links_dispose), (expand_open_links): * shell/ev-sidebar.c: (ev_sidebar_destroy), (ev_sidebar_menu_item_activate_cb), (ev_sidebar_add_page), (ev_sidebar_set_document): * shell/ev-window.c: (ev_window_xfer_job_cb), (sidebar_widget_model_set), (sidebar_page_main_widget_update_cb): Fixed lot's of memory leaks, for example, memory leak on reload, described in bug 307793. --- (limited to 'shell/ev-page-action.c') diff --git a/shell/ev-page-action.c b/shell/ev-page-action.c index 5b45b31..ee4802a 100644 --- a/shell/ev-page-action.c +++ b/shell/ev-page-action.c @@ -345,6 +345,8 @@ match_selected_cb (GtkEntryCompletion *completion, -1); g_signal_emit (proxy, widget_signals[WIDGET_ACTIVATE_LINK], 0, link); + + gtk_tree_iter_free (iter); return TRUE; } @@ -368,6 +370,8 @@ display_completion_text (GtkCellLayout *cell_layout, -1); g_object_set (renderer, "text", ev_link_get_title (link), NULL); + + gtk_tree_iter_free (iter); } static gboolean @@ -389,8 +393,11 @@ match_completion (GtkEntryCompletion *completion, -1); - if (link) + if (link) { text = ev_link_get_title (link); + } + + gtk_tree_iter_free (iter); if (text && key ) { gchar *normalized_text; @@ -461,6 +468,8 @@ update_model (EvPageAction *page, GParamSpec *pspec, EvPageActionWidget *proxy) (GtkCellLayoutDataFunc) display_completion_text, proxy, NULL); gtk_entry_set_completion (GTK_ENTRY (proxy->entry), completion); + + g_object_unref (model); } } -- cgit v0.9.1