#5863 Correctly invalidate icon cache.

2 files changed, 5 insertions, 3 deletions

diff --git a/NEWS b/NEWS
index d006d66..58689b6 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,4 @@
+* #5863 Correctly invalidate icon cache. (tomeu)
 * #3092 Change the color of the preview box. (rwh)
 
 82
diff --git a/misc.py b/misc.py
index b1b8144..3bfebc6 100644
--- a/misc.py
+++ b/misc.py
@@ -48,8 +48,9 @@ _icon_cache = LRU(50)
 
 def get_icon_name(jobject):
 
-    if jobject.object_id in _icon_cache:
-        return _icon_cache[jobject.object_id]
+    cache_key = (jobject.object_id, jobject.metadata.get('timestamp', None))
+    if cache_key in _icon_cache:
+        return _icon_cache[cache_key]
 
     file_name = None
 
@@ -77,7 +78,7 @@ def get_icon_name(jobject):
     if not file_name:
         return _get_icon_file_name('application-octet-stream')
 
-    _icon_cache[jobject.object_id] = file_name
+    _icon_cache[cache_key] = file_name
 
     return file_name