BugFix: Bad way to recognize one image uploaded

2 files changed, 32 insertions, 2 deletions

diff --git a/webapp/polls/tests/poll_tests.py b/webapp/polls/tests/poll_tests.py
index ac94bc8..86e2f60 100644
--- a/webapp/polls/tests/poll_tests.py
+++ b/webapp/polls/tests/poll_tests.py
@@ -6,9 +6,11 @@ from bson import ObjectId
 import os
 
 from polls.models import Poll, Field, Structure
+from polls.views import clean_data, is_image_file
 from polls.forms import PollForm
 from pollster.models import Pollster
 from django.conf import settings
+from django.test import TestCase
 
 from utils.test import MongoTestCase
 
@@ -455,3 +457,28 @@ class AddResultFilesTest(MongoTestCase):
         results = poll.get_result_files(as_instance_of=stub)
         result_filename = results[0]
         self.assertEqual(uploaded_filename, result_filename)
+
+
+class MockImageFileInterface(object):
+
+    def __init__(self):
+        self.name = "a_name.jpg"
+
+
+class CleanDataMustCheckImagesTypes(TestCase):
+
+    def test_is_image(self):
+        image_mock = MockImageFileInterface()
+        self.assertTrue(is_image_file(image_mock))
+
+    def test_it_should_no_raises_with_a_image_file_value(self):
+        data_to_clean = {'some_img': MockImageFileInterface()}
+        try:
+            clean_data(data_to_clean)
+        except AttributeError as e:
+            self.fail(e)
+
+    def test_it_should_strip_values_that_are_not_image_files(self):
+        data_to_clean = {'value': " to strip "}
+        cleaned_data = clean_data(data_to_clean)
+        self.assertEqual("to strip", cleaned_data['value'])
diff --git a/webapp/polls/views.py b/webapp/polls/views.py
index d7adb51..a749ce4 100644
--- a/webapp/polls/views.py
+++ b/webapp/polls/views.py
@@ -17,7 +17,6 @@ from django.http import HttpResponse, HttpResponseRedirect, Http404
 from django.core.urlresolvers import reverse
 from django.views.generic.edit import FormView
 from django.contrib import messages
-from django.core.files.uploadedfile import InMemoryUploadedFile
 from django.shortcuts import render_to_response
 from django.conf import settings
 
@@ -45,6 +44,10 @@ __all__ = [
 ]
 
 
+def is_image_file(value):
+    return hasattr(value, "name")
+
+
 def clean_data(value):
 
     if isinstance(value, dict):
@@ -59,7 +62,7 @@ def clean_data(value):
             value = [clean_data(value_) for value_ in value]
         return value
 
-    if not isinstance(value, InMemoryUploadedFile):
+    if not is_image_file(value):
         value = value.strip(' ')
 
     if value == '':