Web   ·   Wiki   ·   Activities   ·   Blog   ·   Lists   ·   Chat   ·   Meeting   ·   Bugs   ·   Git   ·   Translate   ·   Archive   ·   People   ·   Donate
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWalter Bender <walter@sugarlabs.org>2013-05-25 15:00:39 (GMT)
committer Walter Bender <walter@sugarlabs.org>2013-05-25 15:00:39 (GMT)
commitd8b526eeaffb0e01361d4e6fdd3d1a4598eae099 (patch)
treedb1779bb0ff89c86ef31021edaf98886ea670f79
parent985608a95250f80b25a59e0d6385d03a4f264ee3 (diff)
dsd patch to record problem (OLPC #12686)v42
-rw-r--r--NEWS5
-rw-r--r--activity/activity.info2
-rw-r--r--grecord.py12
3 files changed, 11 insertions, 8 deletions
diff --git a/NEWS b/NEWS
index 64362f1..c19eb54 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,8 @@
+42
+
+BUG FIX:
+* Fixed record problem (tip of the hat to dsd)
+
41
ENHANCEMENT:
diff --git a/activity/activity.info b/activity/activity.info
index d669e4f..3a842e6 100644
--- a/activity/activity.info
+++ b/activity/activity.info
@@ -1,6 +1,6 @@
[Activity]
name = Portfolio
-activity_version = 41
+activity_version = 42
license = GPLv3
bundle_id = org.sugarlabs.PortfolioActivity
exec = sugar-activity PortfolioActivity.PortfolioActivity
diff --git a/grecord.py b/grecord.py
index 92a4a75..8a4b252 100644
--- a/grecord.py
+++ b/grecord.py
@@ -212,20 +212,18 @@ filesink name=audioFilesink'
return True
def _query_position(self, pipe):
- try:
- position, format = pipe.query_position(Gst.Format.TIME)
- except:
+ result, position = pipe.query_position(Gst.Format.TIME)
+ if not result:
position = Gst.CLOCK_TIME_NONE
- try:
- duration, format = pipe.query_duration(Gst.Format.TIME)
- except:
+ result, duration = pipe.query_duration(Gst.Format.TIME)
+ if not result:
duration = Gst.CLOCK_TIME_NONE
return (position, duration)
def _onMuxedAudioMessageCb(self, bus, message, pipe):
- _logger.debug(message.type)
+ # _logger.debug(message.type)
if message.type != Gst.MessageType.EOS:
return True
self._clean_up_transcoding_pipeline(pipe)