1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
|
<?php
/* ***** BEGIN LICENSE BLOCK *****
* Version: MPL 1.1/GPL 2.0/LGPL 2.1
*
* The contents of this file are subject to the Mozilla Public License Version
* 1.1 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
* http://www.mozilla.org/MPL/
*
* Software distributed under the License is distributed on an "AS IS" basis,
* WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
* for the specific language governing rights and limitations under the
* License.
*
* The Original Code is addons.mozilla.org site.
*
* The Initial Developer of the Original Code is
* The Mozilla Foundation.
* Portions created by the Initial Developer are Copyright (C) 2006
* the Initial Developer. All Rights Reserved.
*
* Contributor(s):
* Wil Clouser <clouserw@mozilla.com> (Original Author)
*
* Alternatively, the contents of this file may be used under the terms of
* either the GNU General Public License Version 2 or later (the "GPL"), or
* the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
* in which case the provisions of the GPL or the LGPL are applicable instead
* of those above. If you wish to allow use of your version of this file only
* under the terms of either the GPL or the LGPL, and not to allow others to
* use your version of this file under the terms of the MPL, indicate your
* decision by deleting the provisions above and replace them with the notice
* and other provisions required by the GPL or the LGPL. If you do not delete
* the provisions above, a recipient may use your version of this file under
* the terms of any one of the MPL, the GPL or the LGPL.
*
* ***** END LICENSE BLOCK ***** */
class EditorsControllerTest extends WebTestHelper {
var $testdata = array(
'addonid' => 7, // microfarmer
'tagid' => 2, // viruses
'feature_locales' => 'en-US,fr,de'
);
var $queuedata = array(
'addonid' => 4022,
'name' => 'Chrome List',
'addontypeid' => 1,
'platformid' => 2,
'applicationid' => 1,
);
var $performancedata = array(
'userid' => 5,
);
/**
* Setup the Editors Controller
*/
function testLoad() {
$this->WebTestCase('Editor Feature Tests');
loadModel('Addon');
$this->Addon =& new Addon();
$this->Addon->caching = false;
$this->Addon->cacheQueries = false;
$this->helper = new UnitTestHelper();
$this->controller =& $this->helper->getController('Editors', $this);
$this->helper->mockComponents($this->controller, $this);
}
function testAddFeature() {
$this->assertFalse($this->_checkIfDataExists(), "Make sure the data we're going to use doesn't exist.");
$this->login();
$this->setMaximumRedirects(0);
$this->getAction("/editors/featured/add/{$this->testdata['tagid']}/{$this->testdata['addonid']}/ajax");
$this->assertResponse(array('200'), "Valid AJAX data gets appropriate response.");
$this->assertTrue($this->_checkIfDataExists(), "Valid AJAX data gets inserted into the db");
$this->_removeTestData();
$this->getAction("/editors/featured/add/broken{$this->testdata['tagid']}/blah{$this->testdata['addonid']}/ajax");
$this->assertResponse(array('400'), "Invalid AJAX data gets appropriate response.");
$_data = array( 'data[Addon][id]' => 'Microfarmer [7]', 'data[Tag][id]' => 2);
$this->post($this->actionURI("/editors/featured/add"),$_data);
$this->assertResponse(array('200'), "Valid POST data gets appropriate response.");
$this->assertTrue($this->_checkIfDataExists(), "Valid POST data gets inserted into the db");
$this->_removeTestData();
unset($_data);
$_data = array( 'data[Addon][id]' => '7broken', 'data[Tag][id]' => '2broken');
$this->post($this->actionURI("/editors/featured/add"),$_data);
$this->assertResponse(array('400'), "Invalid POST data gets appropriate response.");
unset($_data);
}
function testEditFeature() {
$this->login();
$this->setMaximumRedirects(0);
$this->_addTestData();
$_data = array('data[AddonTag][feature_locales]' => 'en-US,de');
$this->post($this->actionURI("/editors/featured/edit/{$this->testdata['tagid']}/{$this->testdata['addonid']}/ajax"), $_data);
$this->assertResponse(array('200'), "Valid AJAX edit request with valid data gets accepted.");
$_ret = $this->Addon->execute("SELECT feature_locales FROM `addons_tags` WHERE addon_id={$this->testdata['addonid']} AND tag_id={$this->testdata['tagid']}");
$this->assertEqual('de,en-US', $_ret[0]['AddonTag']['feature_locales'], 'Valid AJAX edit request changes data');
unset($_data, $_ret);
$_data = array('data[AddonTag][feature_locales]' => 'en-US,de');
$this->post($this->actionURI("/editors/featured/edit/{$this->testdata['tagid']}broken/{$this->testdata['addonid']}broken/ajax"), $_data);
$this->assertResponse(array('400'), "Invalid AJAX edit request with valid data gets rejected.");
$_data = array('data[AddonTag][feature_locales]' => 'en-US,broken,de');
$this->post($this->actionURI("/editors/featured/edit/{$this->testdata['tagid']}/{$this->testdata['addonid']}/ajax"), $_data);
$this->assertResponse(array('400'), "Valid AJAX edit request with invalid data gets rejected.");
$_data = array( 'data[Addon][id]' => 7, 'data[Tag][id]' => 2, 'data[AddonTag][feature_locales]' => 'en-US,fr');
$this->post($this->actionURI("/editors/featured/edit"), $_data);
$this->assertResponse(array('200'), "Valid POST edit request with valid data gets accepted.");
$_ret = $this->Addon->execute("SELECT feature_locales FROM `addons_tags` WHERE addon_id={$this->testdata['addonid']} AND tag_id={$this->testdata['tagid']}");
$this->assertEqual('en-US,fr', $_ret[0]['AddonTag']['feature_locales'], 'Valid POST edit request changes data');
unset($_data, $_ret);
$_data = array( 'data[Addon][id]' => 7, 'data[Tag][id]' => '2broken', 'data[AddonTag][feature_locales]' => 'en-US,fr');
$this->post($this->actionURI("/editors/featured/edit"), $_data);
$this->assertResponse(array('400'), "Valid POST edit request with invalid data gets rejected.");
$_data = array( 'data[Addon][id]' => 7, 'data[Tag][id]' => 2, 'data[AddonTag][feature_locales]' => 'en-US,broken,fr');
$this->post($this->actionURI("/editors/featured/edit"), $_data);
$this->assertResponse(array('400'), "Valid POST edit request with invalid locales gets rejected.");
$this->_removeTestData();
}
function testRemoveFeature() {
$this->login();
$this->setMaximumRedirects(0);
$this->_addTestData();
$this->getAction("/editors/featured/remove/{$this->testdata['tagid']}/{$this->testdata['addonid']}");
$this->assertResponse(array('200'), "Valid GET removal request gets appropriate response.");
$this->assertFalse($this->_checkIfDataExists(), "Valid GET removal request removes data.");
$this->getAction("/editors/featured/remove/{$this->testdata['tagid']}broken/{$this->testdata['addonid']}broken");
$this->assertResponse(array('400'), "Invalid GET removal request gets appropriate response.");
}
function testPendingQueueFilter() {
$addonName = $this->queuedata['name'];
$addonAppId = $this->queuedata['applicationid'];
$addonType = $this->queuedata['addontypeid'];
$addonPlatform = $this->queuedata['platformid'];
$nameSearch = substr($addonName, 0, -4);
$path = $this->actionURI('/editors/queue/pending');
// login
$this->login();
// test no filter
$this->get($path);
$this->clickSubmitByName('clear');
$this->assertText($addonName, "'$addonName' in unfiltered queue.");
// filters that include add-on
$this->clickSubmitByName('filter', array('data[Filter][AddonOrAuthor]' => $nameSearch));
$this->assertText($addonName, "'$addonName' in queue with Addon filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][Application]' => $addonAppId));
$this->assertText($addonName, "'$addonName' in queue with Application filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][SubmissionAge]' => '10+'));
$this->assertText($addonName, "'$addonName' in queue with Age filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][Addontype][]' => $addonType));
$this->assertText($addonName, "'$addonName' in queue with Addontype filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][Platform][]' => $addonPlatform));
$this->assertText($addonName, "'$addonName' in queue with Platform filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array(
'data[Filter][AddonOrAuthor]' => $nameSearch,
'data[Filter][Application]' => $addonAppId,
'data[Filter][SubmissionAge]' => '10+',
'data[Filter][Addontype][]' => $addonType,
'data[Filter][AddonPlatform][]' => $addonPlatform)
);
$this->assertText($addonName, "'$addonName' in queue with multi-field filter.");
// filters that exclude add-on
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][AddonOrAuthor]' => "{$nameSearch}wolf!"));
$this->assertNoText($addonName, "'$addonName' not in queue with unmatching Addon filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][Application]' => $addonAppId+12345));
$this->assertNoText($addonName, "'$addonName' not in queue with unmatching Application filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][SubmissionAge]' => 1));
$this->assertNoText($addonName, "'$addonName' not in queue with unmatching Age filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][Addontype][]' => $addonType+12345));
$this->assertNoText($addonName, "'$addonName' not in queue with unmatching Addontype filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][Platform][]' => $addonPlatform+12345));
$this->assertNoText($addonName, "'$addonName' not in queue with unmatching Platform filter.");
}
function testNominatedQueueFilter() {
$addonName = $this->queuedata['name'];
$addonAppId = $this->queuedata['applicationid'];
$addonType = $this->queuedata['addontypeid'];
$nameSearch = substr($addonName, 0, -4);
$path = $this->actionURI('/editors/queue/nominated');
// login
$this->login();
// initially our test add-on should NOT be in the nominated queue
$this->get($path);
$this->clickSubmitByName('clear');
$this->assertNoText($addonName, "'$addonName' (status=PUBLIC) not in unfiltered queue.");
// now temporarily change the status (and nomination date)
$this->_setNominatedStatus();
// test no filter
$this->clickSubmitByName('clear');
$this->assertText($addonName, "'$addonName' in unfiltered queue.");
// filters that include add-on
$this->clickSubmitByName('filter', array('data[Filter][AddonOrAuthor]' => $nameSearch));
$this->assertText($addonName, "'$addonName' in queue with Addon filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][Application]' => $addonAppId));
$this->assertText($addonName, "'$addonName' in queue with Application filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][SubmissionAge]' => '3'));
$this->assertText($addonName, "'$addonName' in queue with Age filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][Addontype][]' => $addonType));
$this->assertText($addonName, "'$addonName' in queue with Addontype filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array(
'data[Filter][AddonOrAuthor]' => $nameSearch,
'data[Filter][Application]' => $addonAppId,
'data[Filter][SubmissionAge]' => 3,
'data[Filter][Addontype][]' => $addonType)
);
$this->assertText($addonName, "'$addonName' in queue with multi-field filter.");
// filters that exclude add-on
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][AddonOrAuthor]' => "{$nameSearch}robot!"));
$this->assertNoText($addonName, "'$addonName' not in queue with unmatching Addon filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][Application]' => $addonAppId+12345));
$this->assertNoText($addonName, "'$addonName' not in queue with unmatching Application filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][SubmissionAge]' => 1));
$this->assertNoText($addonName, "'$addonName' not in queue with unmatching Age filter.");
$this->clickSubmitByName('clear');
$this->clickSubmitByName('filter', array('data[Filter][Addontype][]' => $addonType+12345));
$this->assertNoText($addonName, "'$addonName' not in queue with unmatching Addontype filter.");
// restore changed status
$this->_restoreStatus();
}
function testPerformanceByCategory() {
$summary = $this->controller->_performanceSummaryByCategory($this->performancedata['userid']);
$this->assertTrue(array_sum($summary['usercount']) > 0, 'user has approvals in category breakdown summary');
$this->assertTrue(array_sum($summary['teamcount']) > 0, 'team has approvals in category breakdown summary');
}
function testPerformanceByMonth() {
$summary = $this->controller->_performanceSummaryByMonth($this->performancedata['userid']);
$this->assertTrue(array_sum($summary['usercount']) > 0, 'user has approvals in monthly summary');
$this->assertTrue(array_sum($summary['teamcount']) > 0, 'team has approvals in monthly summary');
}
/**
* We've got to use direct queries here because cake 1.1 doesn't support getting data in join tables. :-/
*/
function _checkIfDataExists() {
$ret = $this->Addon->execute("SELECT addon_id FROM `addons_tags` WHERE addon_id={$this->testdata['addonid']} AND tag_id={$this->testdata['tagid']}");
return !empty($ret);
}
function _addTestData() {
$this->Addon->execute("INSERT INTO `addons_tags` VALUES('{$this->testdata['addonid']}','{$this->testdata['tagid']}', 1, '{$this->testdata['feature_locales']}')");
}
function _removeTestData() {
$this->Addon->execute("DELETE FROM `addons_tags` WHERE addon_id={$this->testdata['addonid']} AND tag_id={$this->testdata['tagid']} LIMIT 1");
}
/**
* Test data doesn't have any nominated addons. We'll use these methods to nominate temporarily
*/
function _setNominatedStatus() {
$this->Addon->execute("UPDATE `addons` SET `status`=".STATUS_NOMINATED.", nominationdate=DATE_SUB(NOW(), INTERVAL 3 DAY) WHERE id={$this->queuedata['addonid']} LIMIT 1");
}
function _restoreStatus() {
$this->Addon->execute("UPDATE `addons` SET `status`=".STATUS_PUBLIC.", nominationdate=0 WHERE id={$this->queuedata['addonid']} LIMIT 1");
}
}
|
