bug 483787, localizing developers.js

git-svn-id: http://svn.mozilla.org/addons/trunk@23544 4eb1ac78-321c-0410-a911-ec516a8615a5

3 files changed, 95 insertions, 22 deletions

diff --git a/site/app/locale/en_US/LC_MESSAGES/messages.po b/site/app/locale/en_US/LC_MESSAGES/messages.po
index b0b50b2..b02cd58 100644
--- a/site/app/locale/en_US/LC_MESSAGES/messages.po
+++ b/site/app/locale/en_US/LC_MESSAGES/messages.po
@@ -780,15 +780,18 @@ msgstr "Incomplete Version"
 msgid "addons_status_nominated"
 msgstr "In Sandbox; Public Nomination"
 
-#: controllers/components/amo.php:195 controllers/components/amo.php:226
+#: views/pages/js_constants.js.thtml:70 controllers/components/amo.php:195
+#: controllers/components/amo.php:226
 msgid "addons_status_pending"
 msgstr "In Sandbox; Pending Review"
 
-#: controllers/components/amo.php:199 controllers/components/amo.php:228
+#: views/pages/js_constants.js.thtml:68 controllers/components/amo.php:199
+#: controllers/components/amo.php:228
 msgid "addons_status_public"
 msgstr "Public"
 
-#: controllers/components/amo.php:193 controllers/components/amo.php:225
+#: views/pages/js_constants.js.thtml:69 controllers/components/amo.php:193
+#: controllers/components/amo.php:225
 msgid "addons_status_sandbox"
 msgstr "In Sandbox"
 
@@ -946,7 +949,7 @@ msgstr "Type"
 msgid "advanced_search_form_version"
 msgstr "version"
 
-#: views/pages/js_constants.js.thtml:68
+#: views/pages/js_constants.js.thtml:84
 msgid "app_compat_ignore_check"
 msgstr "Ignore version check"
 
@@ -3073,6 +3076,59 @@ msgstr "Success"
 msgid "devcp_index_header_myaddons"
 msgstr "My Add-ons"
 
+#: views/pages/js_constants.js.thtml:79
+msgid "devcp_js_a_cancel"
+msgstr "Cancel"
+
+#: views/pages/js_constants.js.thtml:80
+msgid "devcp_js_add_email"
+msgstr "Please enter the account email of the author you wish to add."
+
+#. alt text for a down-arrow image.
+#: views/pages/js_constants.js.thtml:71
+msgid "devcp_js_img_move_down"
+msgstr "Move Down"
+
+#. alt text for an up-arrow image.
+#: views/pages/js_constants.js.thtml:72
+msgid "devcp_js_img_move_up"
+msgstr "Move Up"
+
+#: views/pages/js_constants.js.thtml:81
+msgid "devcp_js_img_remove_compat"
+msgstr "Remove Application Compatibility"
+
+#: views/pages/js_constants.js.thtml:76
+msgid "devcp_js_input_list_author"
+msgstr "List as author in public listings"
+
+#. <option> text in a <select> for Author role in an add-on.
+#: views/pages/js_constants.js.thtml:74
+msgid "devcp_js_option_developer"
+msgstr "Developer"
+
+#. <option> text in a <select> for Author role in an add-on.
+#: views/pages/js_constants.js.thtml:73
+msgid "devcp_js_option_owner"
+msgstr "Owner"
+
+#. <option> text in a <select> for Author role in an add-on.
+#: views/pages/js_constants.js.thtml:75
+msgid "devcp_js_option_viewer"
+msgstr "Viewer"
+
+#: views/pages/js_constants.js.thtml:78
+msgid "devcp_js_remove_author"
+msgstr "Remove Author"
+
+#: views/pages/js_constants.js.thtml:77
+msgid "devcp_js_sure_remove"
+msgstr "Are you <strong>sure</strong> you wish to remove this author?"
+
+#: views/pages/js_constants.js.thtml:67
+msgid "devcp_js_upload_alert"
+msgstr "You must select a file to upload."
+
 #: views/elements/developers/localebox.thtml:44
 msgid "devcp_localebox_header_localizedfields"
 msgstr "Localized Fields"
diff --git a/site/app/views/pages/js_constants.js.thtml b/site/app/views/pages/js_constants.js.thtml
index 10a2474..bd61078 100644
--- a/site/app/views/pages/js_constants.js.thtml
+++ b/site/app/views/pages/js_constants.js.thtml
@@ -64,6 +64,23 @@ var app_compat_older_firefox_only = '<?=___('app_compat_older_firefox_only')?>';
 var app_compat_unreleased_version = '<?=___('app_compat_unreleased_version')?>';
 var app_compat_older_version_or_ignore_check = '<?=___('app_compat_older_version_or_ignore_check')?>';
 
+<?php /* developers.js */ ?>
+var devcp_js_upload_alert = '<?=___('devcp_js_upload_alert')?>';
+var addons_status_public = '<?=___('addons_status_public')?>';
+var addons_status_sandbox = '<?=___('addons_status_sandbox')?>';
+var addons_status_pending = '<?=___('addons_status_pending')?>';
+var devcp_js_img_move_down = '<?=___('devcp_js_img_move_down')?>';
+var devcp_js_img_move_up = '<?=___('devcp_js_img_move_up')?>';
+var devcp_js_option_owner = '<?=___('devcp_js_option_owner')?>';
+var devcp_js_option_developer = '<?=___('devcp_js_option_developer')?>';
+var devcp_js_option_viewer = '<?=___('devcp_js_option_viewer')?>';
+var devcp_js_input_list_author = '<?=___('devcp_js_input_list_author')?>';
+var devcp_js_sure_remove = '<?=___('devcp_js_sure_remove')?>';
+var devcp_js_remove_author = '<?=___('devcp_js_remove_author')?>';
+var devcp_js_a_cancel = '<?=___('devcp_js_a_cancel')?>';
+var devcp_js_add_email = '<?=___('devcp_js_add_email')?>';
+var devcp_js_img_remove_compat = '<?=___('devcp_js_img_remove_compat')?>';
+
 <?php /* Fallback from 4/14/08 */?>
 var app_compat_ignore_check = '<?=___('app_compat_ignore_check')?>';
 
diff --git a/site/app/webroot/js/developers.js b/site/app/webroot/js/developers.js
index c7a745a..0e02c86 100644
--- a/site/app/webroot/js/developers.js
+++ b/site/app/webroot/js/developers.js
@@ -55,7 +55,7 @@ var upload = {
             return true;
         }
         else {
-            alert('You must select a file to upload.');
+            alert(devcp_js_upload_alert);
             return false;
         }
     }
@@ -85,13 +85,13 @@ function iframeLoaded() {
         else if (upload.response.uploadtype == 'update') {
             if (upload.response.status == addon_statuses.PUBLIC) {
                 $('#pending-message').hide();
-                $('#new-file-status').text('Public');
+                $('#new-file-status').text(addons_status_public);
             }
             else if (upload.response.status == addon_statuses.SANDBOX) {
-                $('#new-file-status').text('In Sandbox');
+                $('#new-file-status').text(addons_status_sandbox);
             }
             else if (upload.response.status == addon_statuses.PENDING) {
-                $('#new-file-status').text('In Sandbox; Pending Review');
+                $('#new-file-status').text(addons_status_pending);
             }
             $('#new-file-status').addClass('status-' + upload.response.status);
             $('#new-version-number').text(upload.response.version);
@@ -102,10 +102,10 @@ function iframeLoaded() {
         else if (upload.response.uploadtype == 'file') {
             if (upload.response.status == addon_statuses.PUBLIC) {
                 $('#pending-message').hide();
-                $('#new-file-status').text('Public');
+                $('#new-file-status').text(addons_status_public);
             }
             else if (upload.response.status == addon_statuses.PENDING) {
-                $('#new-file-status').text('In Sandbox; Pending Review');
+                $('#new-file-status').text(addons_status_pending);
             }
             $('#new-file-status').addClass('status-' + upload.response.status);
             $('#queue-count').text(upload.response.queuecount);
@@ -153,22 +153,22 @@ var addon_edit_authors = {
     
     addAuthor: function(user_id, author, role, visible, markChanges) {
         var row = '<tr><td>';
-        row += '<a class="down-arrow" href="#" onclick="addon_edit_authors.moveDownRow(this); return false;"><img src="' + imageURL + '/developers/arrow_down.png" alt="Move Down" title="Move Down" /></a>';
-        row += '<a class="up-arrow" href="#" onclick="addon_edit_authors.moveUpRow(this); return false;"><img src="' + imageURL + '/developers/arrow_up.png" alt="Move Up" title="Move Up" /></a>';
+        row += '<a class="down-arrow" href="#" onclick="addon_edit_authors.moveDownRow(this); return false;"><img src="' + imageURL + '/developers/arrow_down.png" alt="' + devcp_js_img_move_down + '" title="' + devcp_js_img_move_down + '" /></a>';
+        row += '<a class="up-arrow" href="#" onclick="addon_edit_authors.moveUpRow(this); return false;"><img src="' + imageURL + '/developers/arrow_up.png" alt="' + devcp_js_img_move_up + '" title="' + devcp_js_img_move_up + '" /></a>';
         row += '</td><td><a href="' + profileURL + '/' + user_id + '">' + author + '</a></td><td>';
         row += '<select name="data[addons_users][' + user_id + '][role]">';
-        row += '<option value="' + author_roles.OWNER + '" ' + (role == author_roles.OWNER ? ' selected="selected"' : '') + '>Owner</option>';
-        row += '<option value="' + author_roles.DEV + '" ' + (role == author_roles.DEV ? ' selected="selected"' : '') + '>Developer</option>';
-        row += '<option value="' + author_roles.VIEWER + '" ' + (role == author_roles.VIEWER ? ' selected="selected"' : '') + '>Viewer</option>';
+        row += '<option value="' + author_roles.OWNER + '" ' + (role == author_roles.OWNER ? ' selected="selected"' : '') + '>' + devcp_js_option_owner + '</option>';
+        row += '<option value="' + author_roles.DEV + '" ' + (role == author_roles.DEV ? ' selected="selected"' : '') + '>' + devcp_js_option_developer + '</option>';
+        row += '<option value="' + author_roles.VIEWER + '" ' + (role == author_roles.VIEWER ? ' selected="selected"' : '') + '>' + devcp_js_option_viewer + '</option>';
         row += '</td><td>';
-        row += '<input type="checkbox" name="data[addons_users][' + user_id + '][listed]" value="1" ' + (visible == true ? ' checked="checked"' : '') + ' title="List as author in public listings"/>';
+        row += '<input type="checkbox" name="data[addons_users][' + user_id + '][listed]" value="1" ' + (visible == true ? ' checked="checked"' : '') + ' title="' + devcp_js_input_list_author + '"/>';
         row += '</td><td style="width: 25px;">';
         row += '<div class="inline-delete-button uses-image">';
-        row += '<a href="#" onclick="addon_edit_authors.deleteAuthor(this); return false;"><img src="' + imageURL + '/developers/delete.png" alt="Remove Author" title="Remove Author" /></a>';
+        row += '<a href="#" onclick="addon_edit_authors.deleteAuthor(this); return false;"><img src="' + imageURL + '/developers/delete.png" alt="' + devcp_js_remove_author + '" title="' + devcp_js_remove_author + '" /></a>';
         row += '<div class="inline-delete-box">';
-        row += '<p>Are you <b>sure</b> you wish to remove this author?</p><br />';
-        row += '<p><a href="#" onclick="addon_edit_authors.confirmDelete(this); return false;" class="remove-button rounded">Remove Author</a>&nbsp;&nbsp;';
-        row += '<a href="#" onclick="addon_edit_authors.cancelDelete(this); return false;" class="button rounded">Cancel</a></p>';
+        row += '<p>' + devcp_js_sure_remove + '</p><br/>';
+        row += '<p><a href="#" onclick="addon_edit_authors.confirmDelete(this); return false;" class="remove-button rounded">' + devcp_js_remove_author + '</a>&nbsp;&nbsp;';
+        row += '<a href="#" onclick="addon_edit_authors.cancelDelete(this); return false;" class="button rounded">' + devcp_js_a_cancel + '</a></p>';
         row += '</div></div>';
         row += '</td></tr>';
         
@@ -242,7 +242,7 @@ var addon_edit_authors = {
             return true;
         }
         else {
-            $('#add-error').html('Please enter the account email of the author you wish to add.');
+            $('#add-error').html(devcp_js_add_email);
             $('#add-error').slideDown();
             return false;
         }
@@ -383,7 +383,7 @@ var versions_edit = {
         newRow += '<input type="hidden" name="data[Application][' + application_id + '][new]" value="1"/></td>';
         newRow += '<td>' + $('#app' + application_id + '-dropdowns').html() + '</td>';
         newRow += '<td style="width: 25px;"><div class="inline-delete-button">';
-        newRow += '<a href="#" onclick="versions_edit.confirmDelete(this); return false;"><img src="' + imageBase + '/delete.png" alt="Remove Application Compatibility" title="Remove Application Compatibility" /></a>';
+        newRow += '<a href="#" onclick="versions_edit.confirmDelete(this); return false;"><img src="' + imageBase + '/delete.png" alt="' + devcp_js_img_remove_compat + '" title="' + devcp_js_img_remove_compat + '" /></a>';
         newRow += '</div></td>';
         newRow += '</tr>';