Fix stats csv error messages; bug 425724

git-svn-id: http://svn.mozilla.org/addons/trunk@11859 4eb1ac78-321c-0410-a911-ec516a8615a5

1 files changed, 7 insertions, 1 deletions

diff --git a/site/app/controllers/statistics_controller.php b/site/app/controllers/statistics_controller.php
index 6d90dde..69c9f61 100644
--- a/site/app/controllers/statistics_controller.php
+++ b/site/app/controllers/statistics_controller.php
@@ -263,8 +263,10 @@ class StatisticsController extends AppController
         $addon = $this->Addon->find("Addon.id={$addon_id}", null, null, -1);
         
         // Make sure user has permission to view this add-on's stats
-        if (!$this->_checkAccess($addon_id, $addon))
+        if (!$this->_checkAccess($addon_id, $addon)) {
+            $this->Amo->accessDenied();
             return;
+        }
         
         $csv = $this->Stats->historicalPlot($addon_id, $plot);
         
@@ -355,6 +357,10 @@ class StatisticsController extends AppController
         if ($addon['Addon']['publicstats'] == 1)
             return true;
         
+        // If not publicstats, make sure logged in
+        if (!$this->Session->check('User'))
+            return false;
+        
         // If user can view any add-on's stats, allow access
         if ($this->SimpleAcl->actionAllowed('Admin', 'ViewAnyStats', $this->Session->read('User')))
             return true;