| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
This reverts commit a7644fcca13db182cd44378ac1402f17c023e601.
This had implications for SL #3135. Revert for now, an updated
fix can go in a stable update.
|
|
|
|
|
|
|
|
| |
We don't want anyone to be able to alter a file that is inside the data store,
bypassing the API.
Signed-off-by: Sascha Silbe <silbe@activitycentral.com>
Acked-by: Simon Schampijer <simon@laptop.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling datastore.get() and passing the file name back into datastore.update()
for the same entry with transfer_ownership set to False destroyed the data
file.
This was because source and destination file are identical (hard links) and we
overwrote the destination file in AsyncCopy.start() without unlinking it
first.
Fix this by unlinking the destination file if it exists.
Reported-By: Daniel Drake <dsd@laptop.org>
Signed-off-by: Sascha Silbe <silbe@activitycentral.com>
Acked-by: Simon Schampijer <simon@laptop.org>
|
|
|
|
|
|
|
|
| |
The timestamp property might be missing due to incomplete writes (out of
power, system crash) or software bugs.
Signed-off-by: Sascha Silbe <silbe@activitycentral.com>
Acked-by: Simon Schampijer <simon@laptop.org>
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
No other name I can think of is a better fit and no external code is using
this class, so it isn't an issue.
Disabling the warning reduces pylint clutter and makes it easier to spot real
issues.
Signed-off-by: Sascha Silbe <sascha-pgp@silbe.org>
|
|
|
|
|
|
| |
Caught by pylint.
Signed-off-by: Sascha Silbe <sascha-pgp@silbe.org>
|
|
|
|
| |
Signed-off-by: Sascha Silbe <sascha-pgp@silbe.org>
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
This partially(possibly) fixes #2149 issue
|
| |
|
| |
|
| |
|
|
|
|
| |
This will ensure it gets set when upgrading from older datastores.
|
|
|
|
| |
Don't fail indexing if filesize is missing.
|
|
|
|
|
|
|
|
|
| |
This drastically reduces the chance of data loss in the journal on
crash or power failure.
The previous timeout was set to 60 seconds. It is not clear how much
time flushing the journal takes on an XO-1. Until we measure, 5 and 60
are equally unjustified random numbers.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Upgrading directly from 0.82 to 0.86/0.88 didn't migrate the data store
contents because LayoutManager._is_empty() doesn't check for 0.82 data store
entries.
This patch fixes _is_empty() to recognize 0.82 data store contents.
Signed-off-by: Sascha Silbe <sascha-pgp@silbe.org>
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Currently we force an index rescan on migration, but not a rebuild.
Any entry that's already in the index will _not_ be updated.
This patch fixes the migration logic to do a full index rebuild,
thus actually migrating the index.
Signed-off-by: Sascha Silbe <sascha-pgp@silbe.org>
|
| |
|
|
|
|
|
|
| |
Fix file descriptor leak in filestore.retrieve() and use only mkstemp().
Signed-off-by: Sascha Silbe <sascha@silbe.org>
|