From a151135e2e68d1d4128b925565b6f80b1a8e0cfe Mon Sep 17 00:00:00 2001
From: Marco Pesenti Gritti <mpgritti@gmail.com>
Date: Thu, 18 Sep 2008 22:18:31 +0000
Subject: Fix a few pylint warnings.

---
(limited to 'src/sugar/activity/activityfactory.py')

diff --git a/src/sugar/activity/activityfactory.py b/src/sugar/activity/activityfactory.py
index 42ab468..59bddf3 100644
--- a/src/sugar/activity/activityfactory.py
+++ b/src/sugar/activity/activityfactory.py
@@ -17,8 +17,6 @@
 # Boston, MA 02111-1307, USA.
 
 import logging
-import subprocess
-import signal
 
 import dbus
 import gobject
@@ -58,14 +56,14 @@ _RAINBOW_ACTIVITY_FACTORY_INTERFACE = "org.laptop.security.Rainbow"
 # borrowed from subprocess.py
 try:
     MAXFD = os.sysconf("SC_OPEN_MAX")
-except:
+except ValueError:
     MAXFD = 256
 def _close_fds():
     for i in xrange(3, MAXFD):
         try:
             os.close(i)
         except:
-            pass
+            logging.error('Cannot close file file descriptors')
 
 def create_activity_id():
     """Generate a new, unique ID for this activity"""
--
cgit v0.9.1