From 6e01fcbbb01a4d4f412286f98f18c19172977a49 Mon Sep 17 00:00:00 2001
From: Sascha Silbe <sascha@silbe.org>
Date: Sun, 20 Dec 2009 12:54:23 +0000
Subject: fix file descriptor leak in filestore.retrieve()

Fix file descriptor leak in filestore.retrieve().
Minimally invasive version.

Signed-off-by: Sascha Silbe <sascha@silbe.org>
---
diff --git a/src/carquinyol/filestore.py b/src/carquinyol/filestore.py
index 5a90a8e..b0a389b 100644
--- a/src/carquinyol/filestore.py
+++ b/src/carquinyol/filestore.py
@@ -115,10 +115,9 @@ class FileStore(object):
         attempt = 1
         while os.path.exists(destination_path):
             if attempt > 10:
-                fd_, destination_path = tempfile.mkstemp(prefix=uid,
-                                                         suffix=extension,
-                                                         dir=destination_dir)
-                del fd_
+                fd, destination_path = tempfile.mkstemp(prefix=uid,
+                    suffix=extension, dir=destination_dir)
+                os.close(fd)
                 os.unlink(destination_path)
                 break
             else:
--
cgit v0.9.1