Web   ·   Wiki   ·   Activities   ·   Blog   ·   Lists   ·   Chat   ·   Meeting   ·   Bugs   ·   Git   ·   Translate   ·   Archive   ·   People   ·   Donate
summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorMarco Pesenti Gritti <mpgritti@gmail.com>2008-09-18 22:18:31 (GMT)
committer Marco Pesenti Gritti <mpgritti@gmail.com>2008-09-18 22:18:31 (GMT)
commita151135e2e68d1d4128b925565b6f80b1a8e0cfe (patch)
tree2858805fe3fb8a0df9ea92c77cd86891b02c8db8 /src
parente429c258ca174ea287f03381a1fb4700a028084c (diff)
Fix a few pylint warnings.
Diffstat (limited to 'src')
-rw-r--r--src/sugar/activity/activity.py4
-rw-r--r--src/sugar/activity/activityfactory.py6
2 files changed, 4 insertions, 6 deletions
diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index 2a100cf..b55a09d 100644
--- a/src/sugar/activity/activity.py
+++ b/src/sugar/activity/activity.py
@@ -49,7 +49,6 @@ import gettext
import logging
import os
import time
-import tempfile
from hashlib import sha1
import traceback
@@ -469,7 +468,8 @@ class Activity(Window, gtk.Container):
# watch visibility-notify-events to know when we can safely
# take a screenshot of the activity
self.add_events(gtk.gdk.VISIBILITY_NOTIFY_MASK)
- self.connect('visibility-notify-event', self.__visibility_notify_event_cb)
+ self.connect('visibility-notify-event',
+ self.__visibility_notify_event_cb)
self._fully_obscured = True
self._active = False
diff --git a/src/sugar/activity/activityfactory.py b/src/sugar/activity/activityfactory.py
index 42ab468..59bddf3 100644
--- a/src/sugar/activity/activityfactory.py
+++ b/src/sugar/activity/activityfactory.py
@@ -17,8 +17,6 @@
# Boston, MA 02111-1307, USA.
import logging
-import subprocess
-import signal
import dbus
import gobject
@@ -58,14 +56,14 @@ _RAINBOW_ACTIVITY_FACTORY_INTERFACE = "org.laptop.security.Rainbow"
# borrowed from subprocess.py
try:
MAXFD = os.sysconf("SC_OPEN_MAX")
-except:
+except ValueError:
MAXFD = 256
def _close_fds():
for i in xrange(3, MAXFD):
try:
os.close(i)
except:
- pass
+ logging.error('Cannot close file file descriptors')
def create_activity_id():
"""Generate a new, unique ID for this activity"""