From 0b6b6cd6acfedd3bfc326623ad0ccff21c5c4d5e Mon Sep 17 00:00:00 2001
From: Marco Pesenti Gritti <mpg@redhat.com>
Date: Wed, 21 Feb 2007 23:57:49 +0000
Subject: Cleanup the Activity API, code needs more love.

---
(limited to 'sugar/activity/activityfactory.py')

diff --git a/sugar/activity/activityfactory.py b/sugar/activity/activityfactory.py
index 6148466..90b49f7 100644
--- a/sugar/activity/activityfactory.py
+++ b/sugar/activity/activityfactory.py
@@ -36,14 +36,13 @@ class ActivityCreationHandler(gobject.GObject):
         'error':       (gobject.SIGNAL_RUN_FIRST,
                         gobject.TYPE_NONE, 
                        ([gobject.TYPE_PYOBJECT])),
-        'success':     (gobject.SIGNAL_RUN_FIRST,
-                        gobject.TYPE_NONE, 
-                       ([gobject.TYPE_PYOBJECT]))
     }
 
     def __init__(self, service_name, activity_handle):
         gobject.GObject.__init__(self)
 
+        self._service_name = service_name
+
         if activity_handle:
             self._activity_handle = activity_handle
         else:
@@ -91,14 +90,12 @@ class ActivityCreationHandler(gobject.GObject):
         return act_id
 
     def _reply_handler(self, xid):
-        bus = dbus.SessionBus()
-        proxy_obj = bus.get_object(_ACTIVITY_SERVICE_NAME + '%d' % xid,
-                                   _ACTIVITY_SERVICE_PATH + "/%s" % xid)
-        activity = dbus.Interface(proxy_obj, _ACTIVITY_INTERFACE)
-        self.emit('success', activity)
+        logging.debug("Activity created %s (%s)." % 
+            (self._activity_handle.activity_id, self._service_name))
 
     def _error_handler(self, err):
-        logging.debug("Couldn't create activity: %s" % err)
+        logging.debug("Couldn't create activity %s (%s): %s" %
+            (self._activity_handle.activity_id, self._service_name, err))
         self.emit('error', err)
 
 def create(service_name, activity_handle=None):
--
cgit v0.9.1