From 4cf8f321f03317c6156e8fe8544b4b3a9d16bb7a Mon Sep 17 00:00:00 2001
From: Dan Williams <dcbw@redhat.com>
Date: Mon, 09 Apr 2007 19:08:04 +0000
Subject: Fix activity ID generation logic

---
(limited to 'sugar/activity/activityfactory.py')

diff --git a/sugar/activity/activityfactory.py b/sugar/activity/activityfactory.py
index c795c5d..222333e 100644
--- a/sugar/activity/activityfactory.py
+++ b/sugar/activity/activityfactory.py
@@ -47,10 +47,9 @@ def create_activity_id():
             if act_id == act.get_id():
                 found = True
                 break
-        if found:
-            raise RuntimeError("Cannot generate unique activity id.")
-
-    return act_id
+        if not found:
+            return act_id
+    raise RuntimeError("Cannot generate unique activity id.")
 
 class ActivityCreationHandler(gobject.GObject):
     __gsignals__ = {
--
cgit v0.9.1