diff options
author | simpoir <simpoir@Luyten.local> | 2009-03-16 02:41:03 (GMT) |
---|---|---|
committer | simpoir <simpoir@Luyten.local> | 2009-03-16 02:41:03 (GMT) |
commit | a82d9228b66c914782b7cba6c971395be82313e8 (patch) | |
tree | 2e99b85126efb609718e2efd7bf93806bce70b69 /src/sugar/tutorius/actions.py | |
parent | 567021eac56855b16bde1ea2d103becf00552e18 (diff) |
fixes following code review by Erick
overlayer test and fixed non-working code accordingly
Diffstat (limited to 'src/sugar/tutorius/actions.py')
-rw-r--r-- | src/sugar/tutorius/actions.py | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/src/sugar/tutorius/actions.py b/src/sugar/tutorius/actions.py index 915b11b..da8219e 100644 --- a/src/sugar/tutorius/actions.py +++ b/src/sugar/tutorius/actions.py @@ -126,11 +126,18 @@ class BubbleMessage(Action): Show the dialog """ # get or inject overlayer - self.overlay = ObjectStore().activity._overlayer #FIXME:handle subwin + self.overlay = ObjectStore().activity._overlayer + # FIXME: subwindows, are left to overlap this. This behaviour is + # undesirable. subwindows (i.e. child of top level windows) should be + # handled either by rendering over them, or by finding different way to + # draw the overlay. if not self._bubble: x, y = self.position - self._bubble = overlayer.TextBubble(text=self._message, tailpos=self._tailpos) #TODO: add tail handling + # TODO: tails are relative to tailpos. They should be relative to + # the speaking widget. Same of the bubble position. + self._bubble = overlayer.TextBubble(text=self._message, + tailpos=self._tailpos) self._bubble.show() self.overlay.put(self._bubble, x, y) self.overlay.queue_draw() @@ -140,8 +147,6 @@ class BubbleMessage(Action): Destroy the dialog """ if self._bubble: -## self.overlay.remove(self._bubble) -## self.overlay.bin_window.clear() self._bubble.destroy() self._bubble = None |