From dd411ef5c6710d448e47369e8b85d7329e1b1338 Mon Sep 17 00:00:00 2001
From: Simon Poirier <simpoir@gmail.com>
Date: Sun, 22 Nov 2009 18:34:12 +0000
Subject: higher pylint score

---
(limited to 'tutorius/creator.py')

diff --git a/tutorius/creator.py b/tutorius/creator.py
index 68c5fa6..baf7cb3 100644
--- a/tutorius/creator.py
+++ b/tutorius/creator.py
@@ -21,22 +21,19 @@ the activity itself.
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 
-import gtk.gdk
 import gtk.glade
 import gobject
 from gettext import gettext as T
 
 import uuid
 import os
-from sugar.graphics import icon, style
+from sugar.graphics import icon
 
-from . import overlayer, gtkutils, actions, vault, properties, addon
-from . import filters
+from . import overlayer, gtkutils, vault, addon
 from .services import ObjectStore
-from .core import State
 from .tutorial import Tutorial
 from . import viewer
-from .propwidgets import TextInputDialog, StringPropWidget
+from .propwidgets import TextInputDialog
 
 class Creator(object):
     """
@@ -72,15 +69,11 @@ class Creator(object):
         self._eventmenu = None
         self.tuto = None
         self._guid = None
+        self.metadata = None
 
         self._hlmask = overlayer.Rectangle(None, (1.0, 0.0, 0.0, 0.5))
         self._activity._overlayer.put(self._hlmask, 0, 0)
 
-        dlg_width = 300
-        dlg_height = 70
-        sw = gtk.gdk.screen_width()
-        sh = gtk.gdk.screen_height()
-
         self._propedit = ToolBox(self._activity)
         self._propedit.tree.signal_autoconnect({
             'on_quit_clicked': self._cleanup_cb,
@@ -283,7 +276,8 @@ class Creator(object):
                 flags=gtk.DIALOG_MODAL,
                 type=gtk.MESSAGE_QUESTION,
                 buttons=gtk.BUTTONS_YES_NO,
-                message_format=T('Do you want to save before stopping edition?'))
+                message_format=T(
+                    'Do you want to save before stopping edition?'))
             do_save = dialog.run()
             dialog.destroy()
             if do_save == gtk.RESPONSE_YES:
@@ -300,17 +294,22 @@ class Creator(object):
         del self._activity._creator
 
     def save(self, widget=None):
+        """
+        Save the currently edited tutorial to bundle, prompting for
+        a name as needed.
+        """
         if not self._guid:
             self._guid = str(uuid.uuid1())
             dlg = TextInputDialog(parent=self._overview.win,
                                   text=T("Enter a tutorial title."),
                                   field=T("Title"))
-            tutorialName = ""
-            while not tutorialName: tutorialName = dlg.pop()
+            tutorial_name = ""
+            while not tutorial_name:
+                tutorial_name = dlg.pop()
             dlg.destroy()
             self._metadata = {
                 vault.INI_GUID_PROPERTY: self._guid,
-                vault.INI_NAME_PROPERTY: tutorialName,
+                vault.INI_NAME_PROPERTY: tutorial_name,
                 vault.INI_VERSION_PROPERTY: '1',
                 'activities':{os.environ['SUGAR_BUNDLE_NAME']:
                               os.environ['SUGAR_BUNDLE_VERSION']
@@ -330,6 +329,10 @@ class Creator(object):
     launch = staticmethod(launch)
 
 class ToolBox(object):
+    """
+    Palette window for edition tools, including the actions, states and
+    the editable property list of selected actions.
+    """
     ICON_LABEL = 0
     ICON_IMAGE = 1
     ICON_NAME  = 2
@@ -337,7 +340,7 @@ class ToolBox(object):
     def __init__(self, parent):
         super(ToolBox, self).__init__()
         self.__parent = parent
-        sugar_prefix = os.getenv("SUGAR_PREFIX",default="/usr")
+        sugar_prefix = os.getenv("SUGAR_PREFIX", default="/usr")
         glade_file = os.path.join(sugar_prefix, 'share', 'tutorius',
                                   'ui', 'creator.glade')
         self.tree = gtk.glade.XML(glade_file)
@@ -349,9 +352,11 @@ class ToolBox(object):
 
         self._action = None
         self.actions_list = gtk.ListStore(str, gtk.gdk.Pixbuf, str, str)
-        self.actions_list.set_sort_column_id(self.ICON_LABEL, gtk.SORT_ASCENDING)
+        self.actions_list.set_sort_column_id(self.ICON_LABEL,
+                                             gtk.SORT_ASCENDING)
         self.events_list = gtk.ListStore(str, gtk.gdk.Pixbuf, str, str)
-        self.events_list.set_sort_column_id(self.ICON_LABEL, gtk.SORT_ASCENDING)
+        self.events_list.set_sort_column_id(self.ICON_LABEL,
+                                            gtk.SORT_ASCENDING)
 
         for toolname in addon.list_addons():
             meta = addon.get_addon_meta(toolname)
@@ -361,9 +366,13 @@ class ToolBox(object):
             label = format_multiline(meta['display_name'])
 
             if meta['type'] == addon.TYPE_ACTION:
-                self.actions_list.append((label, img, toolname, meta['display_name']))
+                self.actions_list.append(
+                    (label, img, toolname, meta['display_name'])
+                )
             else:
-                self.events_list.append((label, img, toolname, meta['display_name']))
+                self.events_list.append(
+                    (label, img, toolname, meta['display_name'])
+                )
 
         iconview_action = self.tree.get_widget('iconview1')
         iconview_action.set_model(self.actions_list)
@@ -413,7 +422,8 @@ class ToolBox(object):
 
             #Value field
             prop = getattr(type(action), propname)
-            propedit = prop.widget_class(self.__parent, action, propname, self._refresh_action_cb)
+            propedit = prop.widget_class(self.__parent, action, propname,
+                                         self._refresh_action_cb)
             self._propedits.append(propedit)
             row.pack_end(propedit.widget)
 
--
cgit v0.9.1