From 243d29608df4816f791c98407c10fa8a702574e1 Mon Sep 17 00:00:00 2001 From: mike Date: Fri, 04 Dec 2009 02:03:59 +0000 Subject: Creator : Code review changes 1 --- (limited to 'tutorius') diff --git a/tutorius/TProbe.py b/tutorius/TProbe.py index dbadefa..1bf747d 100644 --- a/tutorius/TProbe.py +++ b/tutorius/TProbe.py @@ -391,7 +391,8 @@ class ProbeProxy: (this is only done in edition mode) @return None """ - self._probe.install(pickle.dumps(action), is_editing, + self._probe.install(pickle.dumps(action), + is_editing, reply_handler=save_args(self.__update_action, action, action_installed_cb, editing_cb), error_handler=save_args(error_cb, action)) @@ -409,7 +410,8 @@ class ProbeProxy: if not action_address in self._actions.keys(): raise RuntimeWarning("Action not installed") #TODO Check error handling - return self._probe.update(action_address, pickle.dumps(newaction._props), is_editing, + return self._probe.update(action_address, pickle.dumps(newaction._props), + is_editing, reply_handler=ignore, error_handler=logError) diff --git a/tutorius/creator.py b/tutorius/creator.py index 4ac2033..0d3ac3c 100644 --- a/tutorius/creator.py +++ b/tutorius/creator.py @@ -362,6 +362,8 @@ class Creator(Object): self._probe_mgr.uninstall(action.address, is_editing=True) + # TODO : Support quit cancellation - right now,every time we execute this, + # we will forcibly end edition afterwards. It would be nice to keep creating if kwargs.get('force', False): dialog = gtk.MessageDialog( parent=self._overview.win, @@ -436,7 +438,7 @@ class Creator(Object): @method(BUS_NAME, in_signature='', out_signature='b') - def is_creator_open(self): + def get_authoring_state(self): """ @returns True if the creator is being executed right now, False otherwise. """ -- cgit v0.9.1