Web   ·   Wiki   ·   Activities   ·   Blog   ·   Lists   ·   Chat   ·   Meeting   ·   Bugs   ·   Git   ·   Translate   ·   Archive   ·   People   ·   Donate
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSascha Silbe <silbe@activitycentral.com>2011-10-18 15:46:18 (GMT)
committer Sascha Silbe <silbe@activitycentral.com>2011-10-18 15:46:18 (GMT)
commite50e704364ca78ddc9233f516032552838236de9 (patch)
tree515ea60747da6f42dc5334407fe7b4c57c2da0c2
parent246beca7208ae76a5b1a250a0c74f1a8c3e5f5a4 (diff)
Revert "Don't break if we may not own NetworkManagerUserSettings"
This reverts commit ce2745c8cd3b0b8aaadd0a9900fb74df16eb619a that got pushed by accident.
-rw-r--r--src/jarabe/desktop/meshbox.py2
-rw-r--r--src/jarabe/model/network.py13
2 files changed, 1 insertions, 14 deletions
diff --git a/src/jarabe/desktop/meshbox.py b/src/jarabe/desktop/meshbox.py
index 31f2b67..6d5bb48 100644
--- a/src/jarabe/desktop/meshbox.py
+++ b/src/jarabe/desktop/meshbox.py
@@ -321,7 +321,7 @@ class NetworkManagerObserver(object):
dbus_interface=_NM_IFACE)
settings = network.get_settings()
- if not isinstance(settings, network.DummyNMSettings):
+ if settings is not None:
settings.secrets_request.connect(self.__secrets_request_cb)
def __secrets_request_cb(self, **kwargs):
diff --git a/src/jarabe/model/network.py b/src/jarabe/model/network.py
index e55322b..f265ae4 100644
--- a/src/jarabe/model/network.py
+++ b/src/jarabe/model/network.py
@@ -535,17 +535,6 @@ class NMSettings(dbus.service.Object):
self.connections.pop(uuid)
-class DummyNMSettings(object):
- """
- Dummy object used when we don't own the NetworkManager user settings.
- """
-
- connections = {}
-
- def clear_wifi_connections(self):
- logging.debug('DummyNMSettings.clear_wifi_connections called')
-
-
class SecretsResponse(object):
"""Intermediate object to report the secrets from the dialog
back to the connection object and which will inform NM
@@ -826,8 +815,6 @@ def get_settings():
_nm_settings = NMSettings()
except dbus.DBusException:
logging.exception('Cannot create the UserSettings service.')
- _nm_settings = DummyNMSettings()
-
load_connections()
return _nm_settings