From bad94cfcccf66b77ab1246ea5bdb9799351525d0 Mon Sep 17 00:00:00 2001 From: Simon Schampijer Date: Fri, 24 Jun 2011 13:33:18 +0000 Subject: Journal detail view: sync updates of elements SL #2926 If you did click on the favorite icon and had typed something in the description field before this was lost. We now make sure everything is synced before writing to disk. Acked-by: Simon Schampijer Reviewed-by, Tested-by: Walter Bender --- (limited to 'src') diff --git a/src/jarabe/journal/expandedentry.py b/src/jarabe/journal/expandedentry.py index d293694..476156a 100644 --- a/src/jarabe/journal/expandedentry.py +++ b/src/jarabe/journal/expandedentry.py @@ -379,12 +379,10 @@ class ExpandedEntry(hippo.CanvasBox): def _tags_focus_out_event_cb(self, text_view, event): self._update_entry() - def _update_entry(self): + def _update_entry(self, needs_update=False): if not model.is_editable(self._metadata): return - needs_update = False - old_title = self._metadata.get('title', None) new_title = self._title.props.widget.props.text if old_title != new_title: @@ -422,22 +420,11 @@ class ExpandedEntry(hippo.CanvasBox): return int(self._metadata.get('keep', 0)) == 1 def _keep_icon_activated_cb(self, keep_icon): - if not model.is_editable(self._metadata): - return if self.get_keep(): self._metadata['keep'] = 0 else: self._metadata['keep'] = 1 - - if self._metadata.get('mountpoint', '/') == '/': - model.write(self._metadata, update_mtime=False) - else: - f_path = os.path.join(self._metadata['mountpoint'], - model.get_file_name(self._metadata['title'], - self._metadata['mime_type'])) - model.write(self._metadata, file_path=f_path, - update_mtime=False) - + self._update_entry(needs_update=True) keep_icon.props.keep = self.get_keep() def _icon_button_release_event_cb(self, button, event): -- cgit v0.9.1