Make create_log private

3 files changed, 28 insertions, 28 deletions

diff --git a/devbot/command.py b/devbot/command.py
index 73c2166..aebbb9a 100644
--- a/devbot/command.py
+++ b/devbot/command.py
@@ -4,6 +4,7 @@ import time
 from devbot import utils
 from devbot import config
 
+
 def run(args, test=False, retry=0):
     if test:
         print " ".join(args)
diff --git a/devbot/config.py b/devbot/config.py
index 401ef0b..b9a5bd7 100644
--- a/devbot/config.py
+++ b/devbot/config.py
@@ -89,7 +89,7 @@ def setup(**kwargs):
 
     global log_path
     if "log_name" in kwargs:
-        log_path = create_log(kwargs["log_name"])
+        log_path = _create_log(kwargs["log_name"])
 
 
 def get_source_dir():
@@ -104,31 +104,6 @@ def get_build_dir():
     return _build_dir
 
 
-def create_log(prefix):
-    logfile_path = None
-    number = 0
-
-    while logfile_path is None:
-        name = "%s-%d.log" % (prefix, number)
-        path = os.path.join(logs_dir, name)
-
-        if not os.path.exists(path):
-            logfile_path = path
-
-        number = number + 1
-
-    link_path = os.path.join(logs_dir, "%s.log" % prefix)
-
-    try:
-        os.unlink(link_path)
-    except OSError:
-        pass
-
-    os.symlink(logfile_path, link_path)
-
-    return logfile_path
-
-
 def get_pref(name):
     defaults = {"PROFILE": "default"}
 
@@ -181,6 +156,31 @@ def load_modules():
     return [Module(info) for info in filter(_filter_if, modules)]
 
 
+def create_log(prefix):
+    logfile_path = None
+    number = 0
+
+    while logfile_path is None:
+        name = "%s-%d.log" % (prefix, number)
+        path = os.path.join(logs_dir, name)
+
+        if not os.path.exists(path):
+            logfile_path = path
+
+        number = number + 1
+
+    link_path = os.path.join(logs_dir, "%s.log" % prefix)
+
+    try:
+        os.unlink(link_path)
+    except OSError:
+        pass
+
+    os.symlink(logfile_path, link_path)
+
+    return logfile_path
+
+
 def _filter_if(item):
     if "if" not in item:
         return True
diff --git a/devbot/run.py b/devbot/run.py
index 3f09e89..8d47adb 100644
--- a/devbot/run.py
+++ b/devbot/run.py
@@ -71,8 +71,7 @@ def collect_logs(source_path, log_name):
             with open(path) as f:
                 logs[filename] = f.read()
 
-    log_path = config.create_log(log_name)
-    with open(log_path, "w") as f:
+    with open(config.log_path, "w") as f:
         for filename, log in logs.items():
             f.write("\n===== %s =====\n\n%s" % (filename, log))