Web   ·   Wiki   ·   Activities   ·   Blog   ·   Lists   ·   Chat   ·   Meeting   ·   Bugs   ·   Git   ·   Translate   ·   Archive   ·   People   ·   Donate
summaryrefslogtreecommitdiffstats
path: root/devbot
diff options
context:
space:
mode:
authorDaniel Narvaez <dwnarvaez@gmail.com>2012-11-26 16:58:03 (GMT)
committer Daniel Narvaez <dwnarvaez@gmail.com>2012-11-26 16:58:03 (GMT)
commitd17c4aa7fce1fa4cdcc4d39d675042b87b579067 (patch)
tree2f470d6c6cbcff5ac00cd9c93af64b24b9fab707 /devbot
parentef388964f917c25ea866e537f44f2d88f9e6b85c (diff)
Normalize packages json
Sort, always use a list, json.dump it
Diffstat (limited to 'devbot')
-rw-r--r--devbot/system.py12
1 files changed, 2 insertions, 10 deletions
diff --git a/devbot/system.py b/devbot/system.py
index cdf44f3..4e7ce8c 100644
--- a/devbot/system.py
+++ b/devbot/system.py
@@ -84,11 +84,7 @@ def run_checks(package_manager, checks, packages):
checker = checkers[check["checker"]]
if checker(check["check"]):
if distro_name in packages[check["name"]]:
- package_list = packages[check["name"]][distro_name]
- if not isinstance(package_list, list):
- package_list = [package_list]
-
- for package in package_list:
+ for package in packages[check["name"]][distro_name]:
# Might be none, if so skip on this distro_name
if package and package not in to_install:
to_install.append(package)
@@ -141,11 +137,7 @@ def remove_packages(package_manager, packages):
to_keep = []
for package_info in packages.values():
if distro_name in package_info:
- package_list = package_info[distro_name]
- if not isinstance(package_list, list):
- package_list = [package_list]
-
- for package in package_list:
+ for package in package_info[distro_name]:
if package not in to_keep:
to_keep.append(package)