diff options
| -rw-r--r-- | Makefile.tests | 5 | ||||
| -rw-r--r-- | config/deps/sugar-build.json | 5 | ||||
| -rw-r--r-- | config/packages/deps.json | 11 | ||||
| -rw-r--r-- | devbot/command.py | 1 | ||||
| -rw-r--r-- | devbot/distro.py | 3 | ||||
| -rw-r--r-- | devbot/plugins/debian.py | 1 | ||||
| -rw-r--r-- | devbot/plugins/fedora.py | 1 | ||||
| -rw-r--r-- | devbot/plugins/interfaces.py | 7 | ||||
| -rw-r--r-- | devbot/plugins/unknown.py | 4 | ||||
| -rw-r--r-- | devbot/run.py | 3 | ||||
| -rw-r--r-- | devbot/shell.py | 1 | ||||
| -rw-r--r-- | devbot/system.py | 4 |
12 files changed, 20 insertions, 26 deletions
diff --git a/Makefile.tests b/Makefile.tests index 5438b55..211070b 100644 --- a/Makefile.tests +++ b/Makefile.tests @@ -18,7 +18,10 @@ PYTHON_SCRIPTS = \ $(COMMANDS_DIR)/send-patches \ $(TOOLS_DIR)/json-normalize +pylint: + pylint devbot --disable=C,W,R,E --enable=W0611 + pep8: pep8 commands devbot tests $(PYTHON_SCRIPTS) -check: test-devbot pep8 run-tests +check: test-devbot pep8 pylint run-tests diff --git a/config/deps/sugar-build.json b/config/deps/sugar-build.json index 5e6d4c9..897f93a 100644 --- a/config/deps/sugar-build.json +++ b/config/deps/sugar-build.json @@ -35,6 +35,11 @@ "name": "pep8" }, { + "check": "pylint", + "checker": "binary", + "name": "pylint" + }, + { "check": "scp", "checker": "binary", "name": "scp" diff --git a/config/packages/deps.json b/config/packages/deps.json index 05859ee..5241aea 100644 --- a/config/packages/deps.json +++ b/config/packages/deps.json @@ -1,4 +1,15 @@ { + "pylint": { + "debian": [ + "pylint" + ], + "fedora": [ + "pylint" + ], + "ubuntu": [ + "pylint" + ] + }, "Adwaita": { "debian": [ "gnome-themes-standard" diff --git a/devbot/command.py b/devbot/command.py index aebbb9a..050f809 100644 --- a/devbot/command.py +++ b/devbot/command.py @@ -1,7 +1,6 @@ import subprocess import time -from devbot import utils from devbot import config diff --git a/devbot/distro.py b/devbot/distro.py index 155fb20..681b014 100644 --- a/devbot/distro.py +++ b/devbot/distro.py @@ -1,6 +1,3 @@ -import os -import subprocess - _package_managers = {} _supported_distros = [] _distro_info = None diff --git a/devbot/plugins/debian.py b/devbot/plugins/debian.py index 7b6e1c4..a4e4d67 100644 --- a/devbot/plugins/debian.py +++ b/devbot/plugins/debian.py @@ -1,4 +1,3 @@ -import os import subprocess from devbot import command diff --git a/devbot/plugins/fedora.py b/devbot/plugins/fedora.py index 3b6b694..2e67674 100644 --- a/devbot/plugins/fedora.py +++ b/devbot/plugins/fedora.py @@ -1,4 +1,3 @@ -import os import subprocess from devbot import command diff --git a/devbot/plugins/interfaces.py b/devbot/plugins/interfaces.py index ecd2d3a..1877d85 100644 --- a/devbot/plugins/interfaces.py +++ b/devbot/plugins/interfaces.py @@ -1,10 +1,3 @@ -import os -import subprocess - -from devbot import command -from devbot import distro - - class PackageManager: """Package management""" diff --git a/devbot/plugins/unknown.py b/devbot/plugins/unknown.py index 5e3f530..9db1778 100644 --- a/devbot/plugins/unknown.py +++ b/devbot/plugins/unknown.py @@ -1,7 +1,3 @@ -import os -import subprocess - -from devbot import command from devbot import distro from devbot.plugins import interfaces diff --git a/devbot/run.py b/devbot/run.py index 3bb1920..8f55d65 100644 --- a/devbot/run.py +++ b/devbot/run.py @@ -1,9 +1,6 @@ -#!/usr/bin/python -u - import os import string import random -import shutil import subprocess import sys import time diff --git a/devbot/shell.py b/devbot/shell.py index ba9dfc1..be2730d 100644 --- a/devbot/shell.py +++ b/devbot/shell.py @@ -3,7 +3,6 @@ import os from devbot import environ -from devbot import config def start(rcfile): diff --git a/devbot/system.py b/devbot/system.py index f702fa7..3cf409e 100644 --- a/devbot/system.py +++ b/devbot/system.py @@ -1,12 +1,8 @@ -import json import os import subprocess -import sys from devbot import config -from devbot import git from devbot import distro -from devbot import command from devbot import state from devbot import utils from devbot import xvfb |