From 1c20f570071d99ef56a53cc81cbda2cba6c5b439 Mon Sep 17 00:00:00 2001 From: Daniel Narvaez Date: Fri, 02 Nov 2012 15:46:37 +0000 Subject: If pre-checks fails stop --- diff --git a/scripts/check-system b/scripts/check-system index ab655a4..568a58a 100755 --- a/scripts/check-system +++ b/scripts/check-system @@ -391,10 +391,14 @@ def run_checks(distro, checks): if failed_checks: print "Failed checks\n" + else: + return True for check in failed_checks: print "[%s] %s" % (check["checker"], check["check"]) + return False + def start_xvfb(): xvfb_proc = subprocess.Popen(args=["Xvfb", xvfb_display], stdout=devnull, @@ -466,13 +470,12 @@ def warn_if_unsupported(distro): distro = check_distro() -run_checks(distro, pre_checks) - -xvfb_proc, orig_display = start_xvfb() +if run_checks(distro, pre_checks): + xvfb_proc, orig_display = start_xvfb() -run_checks(distro, checks) + run_checks(distro, checks) -warn_if_unsupported(distro) -apply_distro_tweaks(distro) + warn_if_unsupported(distro) + apply_distro_tweaks(distro) -stop_xvfb(xvfb_proc, orig_display) + stop_xvfb(xvfb_proc, orig_display) -- cgit v0.9.1