pep8 adjustments

- excluded examples because we don't have consensus,
- excluded physics since this is a copy of an upstream,
- excluded query.py since this code does not currently work.

Co-authored-by: Nitin Gupta <gupta.nitingupta.nitin@gmail.com>
Tested-by: James Cameron <quozl@laptop.org>

1 files changed, 50 insertions, 29 deletions

diff --git a/activity.py b/activity.py
index 276818c..0b0ddae 100755
--- a/activity.py
+++ b/activity.py
@@ -1,6 +1,6 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
-# Copyright (C) 2007,2008 One Laptop per Child Association, Inc.
+# Copyright (C) 2007,2008,2010 One Laptop per Child Association, Inc.
 # Written by C. Scott Ananian <cscott@laptop.org>
 #
 # This program is free software; you can redistribute it and/or modify
@@ -19,25 +19,29 @@
 """Pippy activity helper classes."""
 from sugar.activity import activity
 
+
 class ViewSourceActivity(activity.Activity):
     """Activity subclass which handles the 'view source' key."""
     def __init__(self, handle, **kwargs):
         super(ViewSourceActivity, self).__init__(handle, **kwargs)
-        self.__source_object_id = None # XXX: persist this across invocations?
+        self.__source_object_id = None  # XXX: persist this across invocations?
         self.connect('key-press-event', self._key_press_cb)
+
     def _key_press_cb(self, widget, event):
         import gtk
         if gtk.gdk.keyval_name(event.keyval) == 'XF86Start':
             self.view_source()
             return True
         return False
+
     def view_source(self):
         """Implement the 'view source' key by saving pippy_app.py to the
         datastore, and then telling the Journal to view it."""
         if self.__source_object_id is None:
             from sugar import profile
             from sugar.datastore import datastore
-            from sugar.activity.activity import get_bundle_name, get_bundle_path
+            from sugar.activity.activity \
+                 import get_bundle_name, get_bundle_path
             from gettext import gettext as _
             import os.path
             jobject = datastore.create()
@@ -48,13 +52,14 @@ class ViewSourceActivity(activity.Activity):
                 'icon-color': profile.get_color().to_string(),
                 'mime_type': 'text/x-python',
                 }
-            for k,v in metadata.items():
-                jobject.metadata[k] = v # dict.update method is missing =(
+            for k, v in metadata.items():
+                jobject.metadata[k] = v  # dict.update method is missing =(
             jobject.file_path = os.path.join(get_bundle_path(), 'pippy_app.py')
             datastore.write(jobject)
             self.__source_object_id = jobject.object_id
             jobject.destroy()
         self.journal_show_object(self.__source_object_id)
+
     def journal_show_object(self, object_id):
         """Invoke journal_show_object from sugar.activity.activity if it
         exists."""
@@ -62,13 +67,17 @@ class ViewSourceActivity(activity.Activity):
             from sugar.activity.activity import show_object_in_journal
             show_object_in_journal(object_id)
         except ImportError:
-            pass # no love from sugar.
+            pass  # no love from sugar.
 
 TARGET_TYPE_TEXT = 80
+
+
 class VteActivity(ViewSourceActivity):
     """Activity subclass built around the Vte terminal widget."""
     def __init__(self, handle):
-        import gtk, pango, vte
+        import gtk
+        import pango
+        import vte
         from sugar.graphics.toolbutton import ToolButton
         from gettext import gettext as _
         super(VteActivity, self).__init__(handle)
@@ -90,16 +99,16 @@ class VteActivity(ViewSourceActivity):
 
         # creates vte widget
         self._vte = vte.Terminal()
-        self._vte.set_size(30,5)
+        self._vte.set_size(30, 5)
         self._vte.set_size_request(200, 300)
         font = 'Monospace 10'
         self._vte.set_font(pango.FontDescription(font))
-        self._vte.set_colors(gtk.gdk.color_parse ('#000000'),
-                             gtk.gdk.color_parse ('#E7E7E7'),
+        self._vte.set_colors(gtk.gdk.color_parse('#000000'),
+                             gtk.gdk.color_parse('#E7E7E7'),
                              [])
         self._vte.connect('selection-changed', self._on_selection_changed_cb)
         self._vte.drag_dest_set(gtk.DEST_DEFAULT_ALL,
-                                [ ( "text/plain", 0, TARGET_TYPE_TEXT ) ],
+                                [("text/plain", 0, TARGET_TYPE_TEXT)],
                                 gtk.gdk.ACTION_COPY)
         self._vte.connect('drag_data_received', self._on_drop_cb)
         # ...and its scrollbar
@@ -111,7 +120,7 @@ class VteActivity(ViewSourceActivity):
         self.set_canvas(vtebox)
         self.show_all()
         # hide the buttons we don't use.
-        toolbar.share.hide() # this should share bundle.
+        toolbar.share.hide()  # this should share bundle.
         toolbar.keep.hide()
         edittoolbar.undo.hide()
         edittoolbar.redo.hide()
@@ -123,44 +132,54 @@ class VteActivity(ViewSourceActivity):
         bundle_path = activity.get_bundle_path()
         # the 'sleep 1' works around a bug with the command dying before
         # the vte widget manages to snarf the last bits of its output
-        self._pid = self._vte.fork_command \
-                    (command='/bin/sh',
-                     argv=['/bin/sh','-c',
-                           'python %s/pippy_app.py; sleep 1' % bundle_path],
-                     envv=["PYTHONPATH=%s/library" % bundle_path],
-                     directory=bundle_path)
+        self._pid = self._vte.fork_command(
+            command='/bin/sh',
+            argv=['/bin/sh', '-c',
+                  'python %s/pippy_app.py; sleep 1' % bundle_path],
+            envv=["PYTHONPATH=%s/library" % bundle_path],
+            directory=bundle_path)
+
     def _on_copy_clicked_cb(self, widget):
         if self._vte.get_has_selection():
             self._vte.copy_clipboard()
+
     def _on_paste_clicked_cb(self, widget):
         self._vte.paste_clipboard()
+
     def _on_selection_changed_cb(self, widget):
         self._copy_button.set_sensitive(self._vte.get_has_selection())
+
     def _on_drop_cb(self, widget, context, x, y, selection, targetType, time):
         if targetType == TARGET_TYPE_TEXT:
             self._vte.feed_child(selection.data)
+
     def on_child_exit(self, widget):
         """This method is invoked when the user's script exits."""
-        pass # override in subclass
+        pass  # override in subclass
+
 
 class PyGameActivity(ViewSourceActivity):
     """Activity wrapper for a pygame."""
     def __init__(self, handle):
         # fork pygame before we initialize the activity.
-        import os, pygame, sys
+        import os
+        import pygame
+        import sys
         pygame.init()
         windowid = pygame.display.get_wm_info()['wmwindow']
         self.child_pid = os.fork()
         if self.child_pid == 0:
-            library_path = os.path.join(activity.get_bundle_path(), 'library')
-            pippy_app_path = os.path.join(activity.get_bundle_path(), 'pippy_app.py')
-            sys.path[0:0] = [ library_path ]
+            bp = activity.get_bundle_path()
+            library_path = os.path.join(bp, 'library')
+            pippy_app_path = os.path.join(bp, 'pippy_app.py')
+            sys.path[0:0] = [library_path]
             g = globals()
-            g['__name__']='__main__'
-            execfile(pippy_app_path, g, g) # start pygame
+            g['__name__'] = '__main__'
+            execfile(pippy_app_path, g, g)  # start pygame
             sys.exit(0)
         super(PyGameActivity, self).__init__(handle)
-        import gobject, gtk, os
+        import gobject
+        import gtk
         toolbox = activity.ActivityToolbox(self)
         toolbar = toolbox.get_activity_toolbar()
         self.set_toolbox(toolbox)
@@ -174,15 +193,16 @@ class PyGameActivity(ViewSourceActivity):
         socket.grab_focus()
         gobject.child_watch_add(self.child_pid, lambda pid, cond: self.close())
         # hide the buttons we don't use.
-        toolbar.share.hide() # this should share bundle.
+        toolbar.share.hide()  # this should share bundle.
         toolbar.keep.hide()
 
+
 def _main():
     """Launch this activity from the command line."""
     from sugar.activity import activityfactory
     from sugar.activity.registry import ActivityInfo
     from sugar.bundle.activitybundle import ActivityBundle
-    import os, os.path
+    import os
     ab = ActivityBundle(os.path.dirname(__file__) or '.')
     ai = ActivityInfo(name=ab.get_name(),
                       icon=None,
@@ -198,4 +218,5 @@ def _main():
     cmd_args = activityfactory.get_command(ai)
     os.execvpe(cmd_args[0], cmd_args, env)
 
-if __name__=='__main__': _main()
+if __name__ == '__main__':
+    _main()