Web   ·   Wiki   ·   Activities   ·   Blog   ·   Lists   ·   Chat   ·   Meeting   ·   Bugs   ·   Git   ·   Translate   ·   Archive   ·   People   ·   Donate
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorManuel Kaufmann <humitos@gmail.com>2012-10-02 19:24:59 (GMT)
committer Gonzalo Odiard <godiard@gmail.com>2012-10-10 16:24:37 (GMT)
commitb44d38ff96e0b339dc6a2ac56a11bda608dbd122 (patch)
tree67ab0cb0cbb828b0b91d86dd0ddc3b6f18f5a174
parentf7d1a43af5f93e97ba3aea7a97a943e8d5abdef2 (diff)
Remove "capsfilter" filter because of performance
Without this filter the performance to reproduce videos is great and in audio files the visualization performance is improved as well. The only consequense is the text (artist, track, etc) is rendered without antialiasing. Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org> Signed-off-by: Manuel Kaufmann <humitos@gmail.com>
-rw-r--r--jukeboxactivity.py19
1 files changed, 1 insertions, 18 deletions
diff --git a/jukeboxactivity.py b/jukeboxactivity.py
index 5132c68..45bb333 100644
--- a/jukeboxactivity.py
+++ b/jukeboxactivity.py
@@ -754,22 +754,6 @@ class GstPlayer(GObject.GObject):
self.bin.add_pad(ghostpad)
videoscale.set_property("method", 0)
- caps_string = "video/x-raw-yuv, "
- r = self.videowidget.get_allocation()
- if r.width > 500 and r.height > 500:
- # Sigh... xvimagesink on the XOs will scale the video to fit
- # but ximagesink in Xephyr does not. So we live with unscaled
- # video in Xephyr so that the XO can work right.
- w = 480
- h = float(w) / float(float(r.width) / float(r.height))
- caps_string += "width=%d, height=%d" % (w, h)
- else:
- caps_string += "width=480, height=360"
- caps = gst.Caps(caps_string)
- self.filter = gst.element_factory_make("capsfilter", "filter")
- self.bin.add(self.filter)
- self.filter.set_property("caps", caps)
-
textoverlay = gst.element_factory_make('textoverlay')
self.overlay = textoverlay
self.bin.add(textoverlay)
@@ -777,8 +761,7 @@ class GstPlayer(GObject.GObject):
self.bin.add(conv)
videosink = gst.element_factory_make('autovideosink')
self.bin.add(videosink)
- gst.element_link_many(videoscale, self.filter, textoverlay, conv,
- videosink)
+ gst.element_link_many(videoscale, textoverlay, conv, videosink)
self.player.set_property("video-sink", self.bin)
def set_overlay(self, title, artist, album):