From e8b50bd6cc0fd47bd7f7c51007bd549afabbc2c3 Mon Sep 17 00:00:00 2001 From: Sascha Silbe Date: Sun, 17 Oct 2010 10:47:58 +0000 Subject: don't delete bundles on storage media (SL #2456) model.get_file() already wraps data store checkouts in TempFilePath. Because misc.get_bundle() unconditionally wrapped the path returned by model.get_file() in TempFilePath as well, bundles located on storage media (which are referenced by their actual location, not copied or linked) were deleted after misc.get_bundle() finished. --- diff --git a/src/jarabe/journal/misc.py b/src/jarabe/journal/misc.py index 4fcfc60..1817df3 100644 --- a/src/jarabe/journal/misc.py +++ b/src/jarabe/journal/misc.py @@ -108,21 +108,21 @@ def get_date(metadata): def get_bundle(metadata): try: if is_activity_bundle(metadata): - file_path = util.TempFilePath(model.get_file(metadata['uid'])) + file_path = model.get_file(metadata['uid']) if not os.path.exists(file_path): logging.warning('Invalid path: %r', file_path) return None return ActivityBundle(file_path) elif is_content_bundle(metadata): - file_path = util.TempFilePath(model.get_file(metadata['uid'])) + file_path = model.get_file(metadata['uid']) if not os.path.exists(file_path): logging.warning('Invalid path: %r', file_path) return None return ContentBundle(file_path) elif is_journal_bundle(metadata): - file_path = util.TempFilePath(model.get_file(metadata['uid'])) + file_path = model.get_file(metadata['uid']) if not os.path.exists(file_path): logging.warning('Invalid path: %r', file_path) return None -- cgit v0.9.1