From 5a63e31ef7a2ef0fc1dbc266dccb2fce4954d770 Mon Sep 17 00:00:00 2001 From: Martin Abente Date: Wed, 08 Sep 2010 15:11:07 +0000 Subject: Protected Activities Support #2087 Activities deletion causes troubles during classes. Teachers from Paraguay and Uruguay asked for a mechanism to protect activities from being easily deleted. This patch provides a mechanism that uses a gconf value to determine which activities will not contain the erase option at the list view palette. The gconf value contains a list of activities bundle indentifiers. --- diff --git a/data/sugar.schemas.in b/data/sugar.schemas.in index 2e6b820..cfa7edf 100644 --- a/data/sugar.schemas.in +++ b/data/sugar.schemas.in @@ -343,5 +343,19 @@ + + /schemas/desktop/sugar/protected_activities + /desktop/sugar/protected_activities + sugar + list + string + [] + + Bundle IDs of protected activities + Users will not be allowed to erase these + activities through the list view. + + + diff --git a/src/jarabe/desktop/activitieslist.py b/src/jarabe/desktop/activitieslist.py index c14d31e..56b3b5f 100644 --- a/src/jarabe/desktop/activitieslist.py +++ b/src/jarabe/desktop/activitieslist.py @@ -401,13 +401,7 @@ class ActivityListPalette(ActivityPalette): self._favorite_item.show() if activity_info.is_user_activity(): - menu_item = MenuItem(_('Erase'), 'list-remove') - menu_item.connect('activate', self.__erase_activate_cb) - self.menu.append(menu_item) - menu_item.show() - - if not os.access(activity_info.get_path(), os.W_OK): - menu_item.props.sensitive = False + self._add_erase_option(registry, activity_info) registry = bundleregistry.get_registry() self._activity_changed_sid = registry.connect('bundle_changed', @@ -416,6 +410,16 @@ class ActivityListPalette(ActivityPalette): self.connect('destroy', self.__destroy_cb) + def _add_erase_option(self, registry, activity_info): + menu_item = MenuItem(_('Erase'), 'list-remove') + menu_item.connect('activate', self.__erase_activate_cb) + self.menu.append(menu_item) + menu_item.show() + + if not os.access(activity_info.get_path(), os.W_OK) or \ + registry.is_activity_protected(self._bundle_id): + menu_item.props.sensitive = False + def __destroy_cb(self, palette): self.disconnect(self._activity_changed_sid) diff --git a/src/jarabe/model/bundleregistry.py b/src/jarabe/model/bundleregistry.py index b96de86..699e339 100644 --- a/src/jarabe/model/bundleregistry.py +++ b/src/jarabe/model/bundleregistry.py @@ -19,6 +19,7 @@ import os import logging import traceback +import gconf import gobject import gio import simplejson @@ -66,6 +67,14 @@ class BundleRegistry(gobject.GObject): self._last_defaults_mtime = -1 self._favorite_bundles = {} + client = gconf.client_get_default() + self._protected_activities = client.get_list( + '/desktop/sugar/protected_activities', + gconf.VALUE_STRING) + + if self._protected_activities is None: + self._protected_activities = [] + try: self._load_favorites() except Exception: @@ -312,6 +321,9 @@ class BundleRegistry(gobject.GObject): key = self._get_favorite_key(bundle_id, version) return key in self._favorite_bundles + def is_activity_protected(self, bundle_id): + return bundle_id in self._protected_activities + def set_bundle_position(self, bundle_id, version, x, y): key = self._get_favorite_key(bundle_id, version) if key not in self._favorite_bundles: -- cgit v0.9.1