Cancel PDF download when 'X' from TabLabel is clicked SL #4390

When the 'X' button is clicked from the TabLabel we emit 'tab-close'
signal and cancel the download on its callback if the tab closed is a
PDFTabPage.

Signed-off-by: Manuel Kaufmann <humitos@gmail.com>
Acked-by: Manuel Quiñones <manuq@laptop.org>

1 files changed, 6 insertions, 4 deletions

diff --git a/pdfviewer.py b/pdfviewer.py
index e0030ef..40de7ec 100644
--- a/pdfviewer.py
+++ b/pdfviewer.py
@@ -289,7 +289,7 @@ class DummyBrowser(GObject.GObject):
         return 0
 
     def stop_loading(self):
-        self._tab.cancel_download()
+        self._tab.close_tab()
 
     def reload(self):
         pass
@@ -430,7 +430,7 @@ class PDFTabPage(Gtk.HBox):
         # Display a message
         self._message_box = PDFMessageBox(
             message=_("Downloading document..."),
-            button_callback=self.cancel_download)
+            button_callback=self.close_tab)
         self.pack_start(self._message_box, True, True, 0)
         self._message_box.show()
 
@@ -476,10 +476,12 @@ class PDFTabPage(Gtk.HBox):
         logging.debug('Download error! code %s, detail %s: %s' % \
                           (err_code, err_detail, reason))
 
-    def cancel_download(self, button=None):
-        self._download.cancel()
+    def close_tab(self, button=None):
         self._browser.emit_close_tab()
 
+    def cancel_download(self):
+        self._download.cancel()
+
     def __journal_id_to_uri(self, journal_id):
         """Return an URI for a Journal object ID."""
         return "journal://" + journal_id + ".pdf"