Refactor: remove del statement from files valiable

1 files changed, 7 insertions, 7 deletions

diff --git a/webapp/polls/views.py b/webapp/polls/views.py
index 6ca16ee..3571a40 100644
--- a/webapp/polls/views.py
+++ b/webapp/polls/views.py
@@ -361,6 +361,7 @@ class UnploadPollResultFormView(TemplateView):
         files = dict(request.FILES.lists()).get('result', [])
 
         to_json = []
+        valid_files = []
 
         # genera una lista de dict python en to_json
         for index, file_ in enumerate(files):
@@ -368,25 +369,24 @@ class UnploadPollResultFormView(TemplateView):
             try:
                 prf = PollResultFile(path)
                 to_json.append(prf.get_data())
+                valid_files.append(file_)
             except ValueError:
-                del files[index]
                 fname = file_.name
                 msg = u'{0}: No es un .poll_result válido.'.format(fname)
                 messages.add_message(self.request, messages.ERROR, msg)
 
         # si se subió algún archivo:
-        if len(files):
+        if len(valid_files):
             # Esto hace todo
 
             # comprueba si los archivos ya existían y los excluye
             poll_id = to_json[0].get("poll_id", None)
             results_path = "%s/%s" % (settings.RESULT_BCK_ROOT, poll_id)
             uploaded_files = []
-            for index, file in enumerate(files):
+            for index, file in enumerate(valid_files):
                 file_path = "%s/%s" % (results_path, file.name)
                 if os.path.exists(file_path):
                     uploaded_files.append(file.name)
-                    del files[index]
 
             if len(uploaded_files):
                 msg = u'Los siguientes resultados ya se encuentran \
@@ -395,7 +395,7 @@ class UnploadPollResultFormView(TemplateView):
                 messages.add_message(self.request, messages.INFO, msg)
 
             # si no hay más archivos, vuelve al usuario
-            if not len(files):
+            if not len(valid_files):
                 return self.render_to_response(context)
 
             # revisa si el primero de los archivos es del usuario actual
@@ -434,7 +434,7 @@ class UnploadPollResultFormView(TemplateView):
 
                 date_time_string = Clock.get_time_string()
                 uploaded_files = [
-                    (f.name, f.temporary_file_path()) for f in files
+                    (f.name, f.temporary_file_path()) for f in valid_files
                 ]
                 for name, path in uploaded_files:
                     result_file = PollResultFile(path)
@@ -442,7 +442,7 @@ class UnploadPollResultFormView(TemplateView):
                     result_file.set_upload_timestamp(date_time_string)
                     result_file.save()
 
-                processed_files = [file.name for file in files]
+                processed_files = [file.name for file in valid_files]
                 messages.add_message(
                     self.request,
                     messages.SUCCESS,