diff options
| author | rwalsh@mozilla.com <rwalsh@mozilla.com@4eb1ac78-321c-0410-a911-ec516a8615a5> | 2009-08-12 21:58:41 (GMT) |
|---|---|---|
| committer | rwalsh@mozilla.com <rwalsh@mozilla.com@4eb1ac78-321c-0410-a911-ec516a8615a5> | 2009-08-12 21:58:41 (GMT) |
| commit | b21144d2eef0550a2ac911014069802df513bbe8 (patch) | |
| tree | b53e46ba89ed81c6d479de48a91bb7c5e6f5f506 | |
| parent | 08f4575cd1ffbf4c4c7548aa49520ee67eea21fd (diff) | |
Fixing bug 508981
git-svn-id: http://svn.mozilla.org/addons/trunk@49042 4eb1ac78-321c-0410-a911-ec516a8615a5
| -rw-r--r-- | site/app/views/elements/developers/testresults_group.thtml | 17 | ||||
| -rw-r--r-- | site/app/webroot/css/developers.css | 4 | ||||
| -rw-r--r-- | site/app/webroot/js/developers.js | 6 |
3 files changed, 19 insertions, 8 deletions
diff --git a/site/app/views/elements/developers/testresults_group.thtml b/site/app/views/elements/developers/testresults_group.thtml index bae2722..32451af 100644 --- a/site/app/views/elements/developers/testresults_group.thtml +++ b/site/app/views/elements/developers/testresults_group.thtml @@ -36,24 +36,24 @@ * * ***** END LICENSE BLOCK ***** */ -$class = ''; +$group_class = ''; if ($group['counts'][TEST_WARN] == 0 && $group['counts'][TEST_FAIL] == 0) { - $class = 'passed'; + $group_class = 'passed'; } else if ($group['counts'][TEST_FAIL] == 0) { - $class = 'warning'; + $group_class = 'warning'; } else { - $class = 'failed'; + $group_class = 'failed'; } ?> <div class="test-heading" id="test-group-<?=$file['File']['id']?>-<?=$group['TestGroup']['id']?>"> - <h4 class="<?=$class?>"> + <h4 class="<?=$group_class?>"> <?=sprintf(n___('devcp_versions_validate_header_group', 'devcp_versions_validate_header_group', count($group['cases']), '%s results'), $group['TestGroup']['name'])?> </h4> <a href="#test-summary-<?=$file['File']['id']?>"><?=___('devcp_back_to_top', 'Back to Top')?></a> </div> <div id="test-details-<?=$file['File']['id']?>-<?=$group['TestGroup']['id']?>"> <? if (!empty($group['cases'])) : ?> - <? if ($class != 'passed') : ?> + <div class="results-list <?=$group_class?>"> <? foreach ($group['cases'] as $case) : ?> <h5><?=$case['name']?> [<?=$html->link(___('devcp_validation_help', 'help'), '/pages/validation#help-'.$case['id'])?>]</h5> <ul class="test-results"> @@ -107,8 +107,9 @@ if ($group['counts'][TEST_WARN] == 0 && $group['counts'][TEST_FAIL] == 0) { <? endif; ?> </ul> <? endforeach; ?> - <? else: ?> - <i><?= ___('devcp_all_tests_passed', 'All tests passed.') ?></i> + </div> + <? if ($group_class =='passed') : ?> + <i><?= ___('devcp_all_tests_passed', 'All tests passed.') ?> <a href="#" onclick="versions_validate.showPasses($(this)); return false;"><?= n___('devcp_show_validation_passes', 'devcp_show_validation_passes', count($group['cases']), 'Show Pass(es)') ?></a></i> <? endif; ?> <? else: ?> <i><?= ___('devcp_versions_validate_no_results', 'No test results found.') ?></i> diff --git a/site/app/webroot/css/developers.css b/site/app/webroot/css/developers.css index 042ee31..cd01bf4 100644 --- a/site/app/webroot/css/developers.css +++ b/site/app/webroot/css/developers.css @@ -1563,3 +1563,7 @@ ul.radio input { display:none; margin-left: 0.5em; } + +.validation .results-list.passed { + display:none; +}
\ No newline at end of file diff --git a/site/app/webroot/js/developers.js b/site/app/webroot/js/developers.js index 09d8352..601a7d0 100644 --- a/site/app/webroot/js/developers.js +++ b/site/app/webroot/js/developers.js @@ -348,6 +348,12 @@ var versions_validate = { a.parent().slideUp(); }, + showPasses: function(a) { + // Show detailed pass results + a.parent().parent().children('.results-list').slideDown(); + a.parent().slideUp(); + }, + runTest: function(fileId) { // If tests are running, just bail |