Web   ·   Wiki   ·   Activities   ·   Blog   ·   Lists   ·   Chat   ·   Meeting   ·   Bugs   ·   Git   ·   Translate   ·   Archive   ·   People   ·   Donate
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSascha Silbe <silbe@activitycentral.com>2011-02-12 18:08:02 (GMT)
committer Sascha Silbe <silbe@activitycentral.com>2011-02-15 23:06:26 (GMT)
commit7b44b42605a72f99a2285c90542e7cf7629c8752 (patch)
treec292bfe1b5b8e5dc8e80ce4ade099bce6fcaf7e5
parentbfb7922bff09f3e7845a3e77023ae9b3bf5f56fc (diff)
Speaker frame device: pop up palette on left-click instead of toggling mute
Reports from the field indicate that users accidently left-click the Speaker icon and don't realise it got muted. By popping up the palette we enable them to explicitly choose the mute action without instead of surprising them by automatically executing one of the secondary actions (there is no primary action). Signed-off-by: Sascha Silbe <silbe@activitycentral.com> Reviewed-by: James Cameron <quozl@laptop.org>
-rw-r--r--extensions/deviceicon/speaker.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/extensions/deviceicon/speaker.py b/extensions/deviceicon/speaker.py
index b6e33d8..d396bfb 100644
--- a/extensions/deviceicon/speaker.py
+++ b/extensions/deviceicon/speaker.py
@@ -76,12 +76,12 @@ class DeviceView(TrayIcon):
self.icon.props.xo_color = xo_color
def __button_release_event_cb(self, widget, event):
- if event.button == 1:
- self._model.props.muted = not self._model.props.muted
- return True
- else:
+ if event.button != 1:
return False
+ self.palette_invoker.notify_right_click()
+ return True
+
def __expose_event_cb(self, *args):
self._update_info()