Web   ·   Wiki   ·   Activities   ·   Blog   ·   Lists   ·   Chat   ·   Meeting   ·   Bugs   ·   Git   ·   Translate   ·   Archive   ·   People   ·   Donate
summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* XoColor: don't choke if passed the wrong type (SL#1408)HEADmasterSascha Silbe2010-11-301-0/+4
| | | | | | | | | Color data is stored in the Journal as a JSON dump, so we can get back arbitrary types. XoColor already checks the color string for validity and handles invalid strings gracefully, so it makes sense to enhance this to invalid types as well. Acked-by: Simon Schampijer <simon@schampijer.de>
* Apply new version scheme as well to content bundles #2425Simon Schampijer2010-11-251-3/+7
| | | | Reviewed-by: James Cameron <quozl@laptop.org>
* bundlebuilder: install mimetypes.xml and associated icon #2262Simon Schampijer2010-11-241-0/+2
| | | | | | | | As we do create the ActivityBundle in the config of the bundlebuilder we can use the code from the activitybundle as well to install the mime type. Reviewed-By: Sascha Silbe <sascha-pgp@silbe.org>
* bundlebuilder: ignore incorrect pylint warningSascha Silbe2010-11-231-0/+1
| | | | | | | | | pylint isn't smart enough to figure out the return type of Popen.communicate(), so squelch the warning. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint: sugar.wm._property_change_trapped: allow overriding built-in methodSascha Silbe2010-11-231-0/+1
| | | | | | | | | "format" is the name of a parameter of the function we are wrapping, so we shouldn't change it. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* CellRendererInvoker._redraw_path(): assure column is definedSascha Silbe2010-11-231-0/+2
| | | | | | | | | | We know that our code is correct and column should always be assigned, but it never hurts to act defensively and guard against bugs in other pieces of the code (or other components like GTK). Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* ToolInvoker._get_alignments: fix missing self parameterSascha Silbe2010-11-231-1/+1
| | | | | | | | | Caught by pylint. I wonder if we need this piece of code as nobody every triggered it. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint cleanup: initialise all attributes in __init__()Sascha Silbe2010-11-231-0/+1
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint cleanup: pass format parameters to log functions instead of using %Sascha Silbe2010-11-231-2/+2
| | | | | | | | This avoids the overhead from the string formatting on production systems. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint cleanup: disable warnings for reasonable catch-all exception handlersSascha Silbe2010-11-232-0/+2
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* sugar.util: use logging.exception instead of traceback.format_exc()Sascha Silbe2010-11-231-2/+1
| | | | | | | | | logging.exception() handles exceptions nicely for us, no need to explicitly use traceback. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint cleanup: remove unused importsSascha Silbe2010-11-232-4/+1
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint cleanup: replace disable-msg with disableSascha Silbe2010-11-233-5/+5
| | | | | | | | Adapt to upstream format change. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* style cleanup: prefer ' for stringsSascha Silbe2010-11-2338-146/+146
| | | | | | | | | Tomeu prefers ' for strings, so let's use it wherever we don't have a good reason to use ". Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* style cleanup: use """ everywhereSascha Silbe2010-11-232-9/+9
| | | | | | | | Most of the code uses """, so adjust the few deviations. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix deprecated raise syntaxSascha Silbe2010-11-231-1/+1
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix whitespace before ':'Sascha Silbe2010-11-231-1/+1
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix spaces around keyword parametersSascha Silbe2010-11-235-7/+7
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix inline comment spacingSascha Silbe2010-11-232-6/+12
| | | | | | | | pep8 wants inline comments to be prefixed by at least two spaces. Let's just move them to a separate line as that's easier to read anyway. Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix whitespace around operatorSascha Silbe2010-11-236-12/+13
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: don't use has_key()Sascha Silbe2010-11-236-25/+14
| | | | | | | has_key() has been deprecated for quite some time now. Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: ensure lines are shorter than 80 charactersSascha Silbe2010-11-236-14/+20
| | | | | | | | | | Caught by PEP8. This is important for Sugar because the XO has a small screen where long lines would make the code hard to understand (because you need to constantly scroll horizontally). Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer<simon@schampijer.de> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix number of blank linesSascha Silbe2010-11-2314-3/+25
| | | | | | | | Caught by pep8. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* fix EOL spacesSascha Silbe2010-11-234-4/+4
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* Add new numbering scheme #2425Simon Schampijer2010-11-094-7/+167
| | | | | | | - add class NormalizedVersion to parse and compare the new activity versions - change the bundlebuilder and activitybundle to use the new scheme, instead of an int version we expect a string that matches the format defined in NormalizedVersion
*