Web   ·   Wiki   ·   Activities   ·   Blog   ·   Lists   ·   Chat   ·   Meeting   ·   Bugs   ·   Git   ·   Translate   ·   Archive   ·   People   ·   Donate
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSascha Silbe <sascha@silbe.org>2009-12-20 12:54:23 (GMT)
committer Aleksey Lim <alsroot@member.fsf.org>2009-12-20 12:54:23 (GMT)
commit6e01fcbbb01a4d4f412286f98f18c19172977a49 (patch)
treec298e9bd78ea03768c04068f8d6e74a7bd40a9a4
parent7215233beb05ee172e335bc421c40b68ead3d1b4 (diff)
fix file descriptor leak in filestore.retrieve()
Fix file descriptor leak in filestore.retrieve(). Minimally invasive version. Signed-off-by: Sascha Silbe <sascha@silbe.org>
-rw-r--r--src/carquinyol/filestore.py7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/carquinyol/filestore.py b/src/carquinyol/filestore.py
index 5a90a8e..b0a389b 100644
--- a/src/carquinyol/filestore.py
+++ b/src/carquinyol/filestore.py
@@ -115,10 +115,9 @@ class FileStore(object):
attempt = 1
while os.path.exists(destination_path):
if attempt > 10:
- fd_, destination_path = tempfile.mkstemp(prefix=uid,
- suffix=extension,
- dir=destination_dir)
- del fd_
+ fd, destination_path = tempfile.mkstemp(prefix=uid,
+ suffix=extension, dir=destination_dir)
+ os.close(fd)
os.unlink(destination_path)
break
else: