Make pylint a check type

1 files changed, 16 insertions, 13 deletions

diff --git a/scripts/check.py b/scripts/check.py
index 4142d89..1f5eb72 100644
--- a/scripts/check.py
+++ b/scripts/check.py
@@ -19,7 +19,10 @@ class cmd_check(Command):
         Command.__init__(self, [
             make_option('-x', '--xvfb-port', action='store',
                         dest='xvfb_port', default=None,
-                        help='specify the port of the xvfb server')
+                        help='specify the port of the xvfb server'),
+            make_option('-t', '--type', action='store',
+                        dest='type', default=None,
+                        help='specify the check type')
             ])
 
     def start_xvfb(self, port):
@@ -41,7 +44,7 @@ class cmd_check(Command):
         return False
 
     def lint(self, module):
-        return self.run_pylint([module, '--rcfile=%s' % pylintrc_path])
+        self.run_pylint([module, '--rcfile=%s' % pylintrc_path])
 
     def lint_path(self, path):
         cwd = os.getcwd()
@@ -54,23 +57,23 @@ class cmd_check(Command):
                     python_files.append(os.path.join(path, f))
 
         args = ['--rcfile=%s' % pylintrc_path] + python_files
-        result = self.run_pylint(args)
+        self.run_pylint(args)
 
         os.chdir(cwd)
 
-        return result
+    def check_pylint(self, config):
+        sugar_path = os.path.join(config.prefix, 'share', 'sugar')
 
-    def run(self, config, options, args):
-        results = []
+        self.lint_path(os.path.join(sugar_path, 'shell'))
+        self.lint_path(os.path.join(sugar_path, 'service'))
+        self.lint('sugar')
 
+    def run(self, config, options, args):
         self.start_xvfb(options.xvfb_port)
 
-        sugar_path = os.path.join(config.prefix, 'share', 'sugar')
-
-        results.append(self.lint_path(os.path.join(sugar_path, 'shell')))
-        results.append(self.lint_path(os.path.join(sugar_path, 'service')))
-        results.append(self.lint('sugar'))
-
-        return False in results
+        if options.type == 'pylint':
+            self.check_pylint(config)
+        else:
+            return False
 
 register_command(cmd_check)