Web   ·   Wiki   ·   Activities   ·   Blog   ·   Lists   ·   Chat   ·   Meeting   ·   Bugs   ·   Git   ·   Translate   ·   Archive   ·   People   ·   Donate
summaryrefslogtreecommitdiffstats
path: root/src/sugar
Commit message (Collapse)AuthorAgeFilesLines
* Open content bundles on a external device #1748HEADmasterSimon Schampijer2011-03-031-1/+1
| | | | | | | | | | Remove the path parameter as it is not used anyhow. The patch for the sugar module does make sure the method is called correctly. Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org> Acked-By: Simon Schampijer <simon@laptop.org> Reviewed-By: Sascha Silbe<silbe@activitycentral.com>
* Window: allow removing the toolbar_boxSascha Silbe2011-02-171-2/+3
| | | | | | | | Allow the toolbar_box to be removed by setting it to None, like is supported for canvas. Signed-off-by: Sascha Silbe <silbe@activitycentral.com> Acked-by: Simon Schampijer <simon@laptop.org>
* fix whitespace mistake introduced by c7a80a1Sascha Silbe2011-02-151-0/+1
| | | | | Signed-off-by: Sascha Silbe <silbe@activitycentral.com> Acked-by: Simon Schampijer <simon@laptop.org>
* sugar.activity.i18n: add pgettext()Sascha Silbe2011-02-151-0/+18
| | | | | | | | | | Python 2 will never have pgettext() [1], so we need to ship our own version. sugar.activity.i18n is the best place for that. [1] http://bugs.python.org/issue2504#msg122482 Signed-off-by: Sascha Silbe <silbe@activitycentral.com> Acked-by: Simon Schampijer <simon@laptop.org>
* bundlebuilder: genpot: don't use absolute paths in filenames (SL#2508)Simon Schampijer2011-02-121-1/+3
| | | | | | | [tweaked description; minor style fix] Signed-off-by: Sascha Silbe <silbe@activitycentral.com> Tested-By: Sascha Silbe <silbe@activitycentral.com> Reviewed-By: Sascha Silbe <silbe@activitycentral.com>
* Throw MalformedBundleException on broken zip filesMartin Dengler2011-02-051-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sugar.bundle.bundle.Bundle users (e.g. jarabe.model.bundleregistry.BundleRegistry._add_bundle) only expect MalformedBundleException to be thrown, not exceptions of zipfile. This patch solves the most severe issue in #1876: filling up the filesystem with temporary files that won't be deleted afterwards. Before we can consider this bug completely fixed, we still need to do something for the remaining issues: 1) Unpacking shouldn't be attempted if there isn't a safety margin 2) System becomes unresponsive during unpacking 3) No progress indication for the operation, so users are tempted to click multiple times 4) No error messages displayed for unpacking errors, which is a common Sugar nuisance. http://bugs.sugarlabs.org/ticket/1876#comment:5 offers possible strategies for (1) and (2). Signed-off-by: Martin Dengler <martin@martindengler.com> Signed-off-by: Bernie Innocenti <bernie@codewiz.org> [style fixes, adjusted description] Signed-off-by: Sascha Silbe <silbe@activitycentral.com> Reviewed-by: Aleksey Lim <alsroot@activitycentral.org>
* fix sugar-emulator detection logic broken by 814ab2d (has_key() cleanup)Sascha Silbe2011-02-051-1/+1
| | | | | | This broke Shutdown and Restart (buddy menu). Signed-off-by: Sascha Silbe <silbe@activitycentral.com>
* XoColor: don't choke if passed the wrong type (SL#1408)Sascha Silbe2010-11-301-0/+4
| | | | | | | | | Color data is stored in the Journal as a JSON dump, so we can get back arbitrary types. XoColor already checks the color string for validity and handles invalid strings gracefully, so it makes sense to enhance this to invalid types as well. Acked-by: Simon Schampijer <simon@schampijer.de>
* Apply new version scheme as well to content bundles #2425Simon Schampijer2010-11-251-3/+7
| | | | Reviewed-by: James Cameron <quozl@laptop.org>
* bundlebuilder: install mimetypes.xml and associated icon #2262Simon Schampijer2010-11-241-0/+2
| | | | | | | | As we do create the ActivityBundle in the config of the bundlebuilder we can use the code from the activitybundle as well to install the mime type. Reviewed-By: Sascha Silbe <sascha-pgp@silbe.org>
* bundlebuilder: ignore incorrect pylint warningSascha Silbe2010-11-231-0/+1
| | | | | | | | | pylint isn't smart enough to figure out the return type of Popen.communicate(), so squelch the warning. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint: sugar.wm._property_change_trapped: allow overriding built-in methodSascha Silbe2010-11-231-0/+1
| | | | | | | | | "format" is the name of a parameter of the function we are wrapping, so we shouldn't change it. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* CellRendererInvoker._redraw_path(): assure column is definedSascha Silbe2010-11-231-0/+2
| | | | | | | | | | We know that our code is correct and column should always be assigned, but it never hurts to act defensively and guard against bugs in other pieces of the code (or other components like GTK). Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* ToolInvoker._get_alignments: fix missing self parameterSascha Silbe2010-11-231-1/+1
| | | | | | | | | Caught by pylint. I wonder if we need this piece of code as nobody every triggered it. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint cleanup: initialise all attributes in __init__()Sascha Silbe2010-11-231-0/+1
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint cleanup: pass format parameters to log functions instead of using %Sascha Silbe2010-11-231-2/+2
| | | | | | | | This avoids the overhead from the string formatting on production systems. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint cleanup: disable warnings for reasonable catch-all exception handlersSascha Silbe2010-11-232-0/+2
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* sugar.util: use logging.exception instead of traceback.format_exc()Sascha Silbe2010-11-231-2/+1
| | | | | | | | | logging.exception() handles exceptions nicely for us, no need to explicitly use traceback. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint cleanup: remove unused importsSascha Silbe2010-11-232-4/+1
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* pylint cleanup: replace disable-msg with disableSascha Silbe2010-11-233-5/+5
| | | | | | | | Adapt to upstream format change. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* style cleanup: prefer ' for stringsSascha Silbe2010-11-2327-134/+134
| | | | | | | | | Tomeu prefers ' for strings, so let's use it wherever we don't have a good reason to use ". Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* style cleanup: use """ everywhereSascha Silbe2010-11-232-9/+9
| | | | | | | | Most of the code uses """, so adjust the few deviations. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix deprecated raise syntaxSascha Silbe2010-11-231-1/+1
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix whitespace before ':'Sascha Silbe2010-11-231-1/+1
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix spaces around keyword parametersSascha Silbe2010-11-235-7/+7
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix inline comment spacingSascha Silbe2010-11-232-6/+12
| | | | | | | | pep8 wants inline comments to be prefixed by at least two spaces. Let's just move them to a separate line as that's easier to read anyway. Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix whitespace around operatorSascha Silbe2010-11-236-12/+13
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: don't use has_key()Sascha Silbe2010-11-236-25/+14
| | | | | | | has_key() has been deprecated for quite some time now. Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: ensure lines are shorter than 80 charactersSascha Silbe2010-11-235-10/+14
| | | | | | | | | | Caught by PEP8. This is important for Sugar because the XO has a small screen where long lines would make the code hard to understand (because you need to constantly scroll horizontally). Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer<simon@schampijer.de> CC: Aleksey Lim <alsroot@member.fsf.org>
* PEP8 cleanup: fix number of blank linesSascha Silbe2010-11-238-2/+15
| | | | | | | | Caught by pep8. Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* fix EOL spacesSascha Silbe2010-11-232-2/+2
| | | | | | Reviewed-by: James Cameron <quozl@laptop.org> Acked-by: Simon Schampijer <simon@laptop.org> CC: Aleksey Lim <alsroot@member.fsf.org>
* Add new numbering scheme #2425Simon Schampijer2010-11-094-7/+167
| | | | | | | - add class NormalizedVersion to parse and compare the new activity versions - change the bundlebuilder and activitybundle to use the new scheme, instead of an int version we expect a string that matches the format defined in NormalizedVersion
* Add 'cache-palette' property to Invoker #1742Tomeu Vizoso2010-10-142-3/+21
| | | | Meaning that the palette will be cached after it's created.
* Fix running multiple instances of Browse by adapting to API changes #2404Tomeu Vizoso2010-10-052-4/+9
| | | | | | | | * sugar/presence/presenceservice.py: Specify the D-Bus interface when calling ActivityProperties.GetActivity * sugar/activity/main.py: Set a default for the --invite option and make the create() D-Bus method accept a{sv} so we can pass the boolean value.
* Cast floats to ints before calling cairo.ImageSurface() #2291Tomeu Vizoso2010-10-041-4/+6
| | | | Otherwise Python 2.7 will raise an exception.
* Do not break if the string contains no conversion specifier #2354Simon Schampijer2010-09-291-4/+11
|
* Don't try to share the activity if we couldn't find a suitable connection #2217Tomeu Vizoso2010-09-101-0/+6
|
* sugar.presence: Remove dead code and make clear which methonds are deprecatedTomeu Vizoso2010-08-302-150/+21
|
* Read the public and private keys lazilyTomeu Vizoso2010-08-261-2/+13
|
* Use Account.ConnectionStatus instead of Account.Connection.StatusTomeu Vizoso2010-08-261-1/+2
|
* Merge branch 'master' of gitorious@git.sugarlabs.org:sugar-toolkit/mainlineMartin Abente2010-08-231-14/+0
|\
| * Remove sugar/__init__.py, it should come from sugar-base #1868Tomeu Vizoso2010-08-231-14/+0
| |
* | Delete activities profile data when uninstall #2074Martin Abente2010-08-231-1/+8
|/ | | | | | | | When activities are uninstalled, profile data persists. Profile data can consume a lot of storage space. Therefore it is necessary to delete it when required. Signed-off-by: Martin Abente <mabente@paraguayeduca.org>
* Address comments from Simon's reviewTomeu Vizoso2010-08-203-179/+8
|
* Address several nitpicks from MarcoTomeu Vizoso2010-08-205-27/+35
|
* Rename ActivityHandle.handle_invite to ActivityHandle.invitedTomeu Vizoso2010-08-204-10/+10
|
* Remove unused constantTomeu Vizoso2010-08-201-1/+0
|
* Add copyright statement due to the collaboration refactoringTomeu Vizoso2010-08-202-0/+2
|
* Misc. pylint fixesTomeu Vizoso2010-08-205-119/+12
|
* Wrap lines with more than 80 charsTomeu Vizoso2010-08-203-22/+43
|