diff options
author | Sascha Silbe <sascha-pgp@silbe.org> | 2010-10-16 09:39:58 (GMT) |
---|---|---|
committer | Sascha Silbe <sascha-pgp@silbe.org> | 2010-11-23 17:03:20 (GMT) |
commit | 71032dff439806443eee86b4e5a6af86a843941a (patch) | |
tree | dc456e23e8f921c50b0ff392de540c75a7fb9049 | |
parent | 0e5b75730e3fb78fb46f130fd17d50a3f8f6fdc1 (diff) |
style cleanup: prefer ' for strings
Tomeu prefers ' for strings, so let's use it wherever we don't have a good
reason to use ".
Reviewed-by: James Cameron <quozl@laptop.org>
Acked-by: Simon Schampijer <simon@laptop.org>
-rw-r--r-- | src/sugar/dispatch/saferef.py | 2 | ||||
-rw-r--r-- | src/sugar/logger.py | 10 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/sugar/dispatch/saferef.py b/src/sugar/dispatch/saferef.py index 709d292..1632b34 100644 --- a/src/sugar/dispatch/saferef.py +++ b/src/sugar/dispatch/saferef.py @@ -190,7 +190,7 @@ class BoundNonDescriptorMethodWeakref(BoundMethodWeakref): an attribute named differenty than the function's name such as in: class A: pass - def foo(self): return "foo" + def foo(self): return 'foo' A.bar = foo But this shouldn't be a common use case. So, on platforms where methods diff --git a/src/sugar/logger.py b/src/sugar/logger.py index 3837857..ebb766d 100644 --- a/src/sugar/logger.py +++ b/src/sugar/logger.py @@ -113,7 +113,7 @@ def start(log_filename=None): traceback.print_stack() logging.basicConfig(level=logging.WARNING, - format="%(created)f %(levelname)s %(name)s: %(message)s", + format='%(created)f %(levelname)s %(name)s: %(message)s', stream=SafeLogWrapper(sys.stderr)) root_logger.handlers[0].handleError = handleError @@ -182,22 +182,22 @@ def trace(logger=None, logger_name=None, skip_args=None, skip_kwargs=None, if not enabled: return f(*args, **kwargs) - params_formatted = ", ".join( + params_formatted = ', '.join( [trace_repr.repr(a) for (idx, a) in enumerate(args) if idx not in skip_args] + \ ['%s=%s' % (k, trace_repr.repr(v)) for (k, v) in kwargs.items() if k not in skip_kwargs]) - trace_logger.log(TRACE, "%s(%s) invoked", f.__name__, + trace_logger.log(TRACE, '%s(%s) invoked', f.__name__, params_formatted) try: res = f(*args, **kwargs) except: - trace_logger.exception("Exception occured in %s", f.__name__) + trace_logger.exception('Exception occured in %s', f.__name__) raise - trace_logger.log(TRACE, "%s(%s) returned %s", f.__name__, + trace_logger.log(TRACE, '%s(%s) returned %s', f.__name__, params_formatted, trace_repr.repr(res)) return res |