diff options
author | Marco Pesenti Gritti <marco@localhost.localdomain> | 2008-08-09 21:33:28 (GMT) |
---|---|---|
committer | Marco Pesenti Gritti <marco@localhost.localdomain> | 2008-08-09 21:33:28 (GMT) |
commit | ed0e67bb5fe2dce9b8727fe5dd50f1b495bc0081 (patch) | |
tree | dca27eb416e14710c2d4cdcee258a73874d6b066 /scripts | |
parent | 3c03cf2c03377447ea913c19f002661ac364323c (diff) |
Cleanups
Diffstat (limited to 'scripts')
-rw-r--r-- | scripts/check.py | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/scripts/check.py b/scripts/check.py index 1f5eb72..701b90c 100644 --- a/scripts/check.py +++ b/scripts/check.py @@ -37,14 +37,8 @@ class cmd_check(Command): except OSError: print 'Cannot execute xfvb, will use the default display.' - def run_pylint(self, args): - p = subprocess.Popen([ 'pylint' ] + args) - p.wait() - - return False - def lint(self, module): - self.run_pylint([module, '--rcfile=%s' % pylintrc_path]) + subprocess.call(['pylint', '--rcfile=%s' % pylintrc_path]) def lint_path(self, path): cwd = os.getcwd() @@ -56,16 +50,19 @@ class cmd_check(Command): if f.endswith('.py'): python_files.append(os.path.join(path, f)) - args = ['--rcfile=%s' % pylintrc_path] + python_files - self.run_pylint(args) + args = ['pylint', '--rcfile=%s' % pylintrc_path] + subprocess.call(args + python_files) os.chdir(cwd) def check_pylint(self, config): sugar_path = os.path.join(config.prefix, 'share', 'sugar') + print 'Pylint the sugar shell...' self.lint_path(os.path.join(sugar_path, 'shell')) self.lint_path(os.path.join(sugar_path, 'service')) + + print 'Pylint the sugar module...' self.lint('sugar') def run(self, config, options, args): |