diff options
Diffstat (limited to 'rpms/sugar/avoid-popping-an-empty-list-in-the-software-updater.patch')
| -rw-r--r-- | rpms/sugar/avoid-popping-an-empty-list-in-the-software-updater.patch | 36 |
1 files changed, 0 insertions, 36 deletions
diff --git a/rpms/sugar/avoid-popping-an-empty-list-in-the-software-updater.patch b/rpms/sugar/avoid-popping-an-empty-list-in-the-software-updater.patch deleted file mode 100644 index a9a2245..0000000 --- a/rpms/sugar/avoid-popping-an-empty-list-in-the-software-updater.patch +++ /dev/null @@ -1,36 +0,0 @@ -Date: Sun, 23 May 2010 14:50:16 -0400 -From: Michael Stone <michael@laptop.org> -To: sugar-devel@lists.sugarlabs.org -Subject: [Sugar-devel] [PATCH] Avoid popping an empty list in the software - updater. - -When you run Sugar with no activities installed, UpdateModel._bundles_to_check -is empty. Attempting to unconditionally pop this list results in an IndexError. -Instead, the updater should stop trying to update bundles when it determines -that it has no more bundles to check. - -Signed-off-by: Michael Stone <michael@laptop.org> ---- - extensions/cpsection/updater/model.py | 2 ++ - 1 files changed, 2 insertions(+), 0 deletions(-) - -diff --git a/extensions/cpsection/updater/model.py b/extensions/cpsection/updater/model.py -index f2de65b..c45dcd3 100755 ---- a/extensions/cpsection/updater/model.py -+++ b/extensions/cpsection/updater/model.py -@@ -71,6 +71,8 @@ class UpdateModel(gobject.GObject): - total = len(bundleregistry.get_registry()) - current = total - len(self._bundles_to_check) - -+ if len(self._bundles_to_check) == 0: -+ return False - bundle = self._bundles_to_check.pop() - self.emit('progress', UpdateModel.ACTION_CHECKING, bundle.get_name(), - current, total) --- -1.7.1 -_______________________________________________ -Sugar-devel mailing list -Sugar-devel@lists.sugarlabs.org -http://lists.sugarlabs.org/listinfo/sugar-devel - |