Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | XoColor: don't choke if passed the wrong type (SL#1408)HEADrefs/top-bases/t/accessibility-namesmaster | Sascha Silbe | 2010-10-22 | 1 | -0/+4 |
| | | | | | | | Color data is stored in the Journal as a JSON dump, so we can get back arbitrary types. XoColor already checks the color string for validity and handles invalid strings gracefully, so it makes sense to enhance this to invalid types as well. | ||||
* | bundlebuilder: ignore incorrect pylint warning | Sascha Silbe | 2010-10-22 | 1 | -0/+1 |
| | | | | | pylint isn't smart enough to figure out the return type of Popen.communicate(), so squelch the warning. | ||||
* | pylint: sugar.wm._property_change_trapped: allow overriding built-in method | Sascha Silbe | 2010-10-22 | 1 | -0/+1 |
| | | | | | "format" is the name of a parameter of the function we are wrapping, so we shouldn't change it. | ||||
* | CellRendererInvoker._redraw_path(): assure column is defined | Sascha Silbe | 2010-10-22 | 1 | -0/+2 |
| | | | | | | We know that our code is correct and column should always be assigned, but it never hurts to act defensively and guard against bugs in other pieces of the code (or other components like GTK). | ||||
* | ToolInvoker._get_alignments: fix missing self parameter | Sascha Silbe | 2010-10-22 | 1 | -1/+1 |
| | | | | | Caught by pylint. I wonder if we need this piece of code as nobody every triggered it. | ||||
* | pylint cleanup: initialise all attributes in __init__() | Sascha Silbe | 2010-10-22 | 1 | -0/+1 |
| | |||||
* | pylint cleanup: pass format parameters to log functions instead of using % | Sascha Silbe | 2010-10-22 | 1 | -2/+2 |
| | | | | This avoids the overhead from the string formatting on production systems. | ||||
* | pylint cleanup: disable warnings for reasonable catch-all exception handlers | Sascha Silbe | 2010-10-22 | 2 | -0/+2 |
| | |||||
* | sugar.util: use logging.exception instead of traceback.format_exc() | Sascha Silbe | 2010-10-22 | 1 | -2/+1 |
| | | | | | logging.exception() handles exceptions nicely for us, no need to explicitly use traceback. | ||||
* | pylint cleanup: remove unused import | Sascha Silbe | 2010-10-22 | 1 | -2/+1 |
| | |||||
* | pylint cleanup: replace disable-msg with disable | Sascha Silbe | 2010-10-22 | 3 | -5/+5 |
| | | | | Adapt to upstream format change. | ||||
* | style cleanup: prefer ' for strings | Sascha Silbe | 2010-10-22 | 38 | -146/+146 |
| | | | | | Tomeu prefers ' for strings, so let's use it wherever we don't have a good reason to use ". | ||||
* | style cleanup: use """ everywhere | Sascha Silbe | 2010-10-22 | 2 | -9/+9 |
| | | | | Most of the code uses """, so adjust the few deviations. | ||||
* | PEP8 cleanup: fix deprecated raise syntax | Sascha Silbe | 2010-10-22 | 1 | -1/+1 |
| | |||||
* | PEP8 cleanup: fix whitespace before ':' | Sascha Silbe | 2010-10-22 | 1 | -1/+1 |
| | |||||
* | PEP8 cleanup: fix spaces around keyword parameters | Sascha Silbe | 2010-10-22 | 5 | -7/+7 |
| | |||||
* | PEP8 cleanup: fix inline comment spacing | Sascha Silbe | 2010-10-22 | 2 | -6/+12 |
| | | | | | pep8 wants inline comments to be prefixed by at least two spaces. Let's just move them to a separate line as that's easier to read anyway. | ||||
* | PEP8 cleanup: fix whitespace around operator | Sascha Silbe | 2010-10-22 | 4 | -6/+7 |
| | | | | | I've left the powers as-is because IMO they should directly follow the base, unlike other operators. | ||||
* | PEP8 cleanup: don't use has_key() | Sascha Silbe | 2010-10-22 | 6 | -25/+14 |
| | | | | has_key() has been deprecated for quite some time now. | ||||
* | PEP8 cleanup: ensure lines are shorter than 80 characters | Sascha Silbe | 2010-10-22 | 6 | -14/+20 |
| | | | | | | Caught by PEP8. This is important for Sugar because the XO has a small screen where long lines would make the code hard to understand (because you need to constantly scroll horizontally). | ||||
* | PEP8 cleanup: fix number of blank lines | Sascha Silbe | 2010-10-22 | 14 | -3/+25 |
| | | | | Caught by pep8. | ||||
* | fix EOL spaces | Sascha Silbe | 2010-10-22 | 4 | -4/+4 |
| | |||||
* |