Web   ·   Wiki   ·   Activities   ·   Blog   ·   Lists   ·   Chat   ·   Meeting   ·   Bugs   ·   Git   ·   Translate   ·   Archive   ·   People   ·   Donate
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeff Balogh <jbalogh@mozilla.com>2010-09-03 20:09:14 (GMT)
committer Jeff Balogh <jbalogh@mozilla.com>2010-09-03 20:09:14 (GMT)
commitfb1f5259bf84acb977befaf95f28cda1299fda7c (patch)
treef4eeca5bf63e1598a26acd9e11954054fb058cf7
parent0af82fe265fcc3adace2dca6b9f38b7fe3fba91e (diff)
UX fixes for spam page
-rw-r--r--apps/reviews/templates/reviews/spam.html12
-rw-r--r--apps/reviews/views.py7
2 files changed, 16 insertions, 3 deletions
diff --git a/apps/reviews/templates/reviews/spam.html b/apps/reviews/templates/reviews/spam.html
index 25cc4f7..2894f90 100644
--- a/apps/reviews/templates/reviews/spam.html
+++ b/apps/reviews/templates/reviews/spam.html
@@ -12,16 +12,26 @@
('numbers', 'Overwhelmingly Productive'),
) %}
+{% set trans = {
+ 'urls': 'containing urls',
+ 'numbers': 'creating too many reviews',
+ 'matches': 'duplicate content',
+} %}
+
{% for key, title in keys %}
{% if buckets[key] %}
<div>
<h3>{{ title }}</h3>
{% for review in buckets[key] %}
- <form method="post" action="">
+ <form method="post" action="" style="margin-bottom: 2em">
{{ csrf() }}
{% with addon = review.addon %}
{% include "reviews/review.html" %}
{% endwith %}
+ <p style="margin-bottom: .4em">
+ For <a href="{{ review.addon.get_url_path() }}">{{ review.addon.name }}</a>
+ &mdash; flagged for {{ trans[key] }}.
+ </p>
<input type="hidden" name="review" value="{{ review.id }}">
<input type="hidden" name="addon" value="{{ review.addon_id }}">
<input type="submit" name="del_user" value="Delete User">
diff --git a/apps/reviews/views.py b/apps/reviews/views.py
index 7907c81..340dca2 100644
--- a/apps/reviews/views.py
+++ b/apps/reviews/views.py
@@ -204,8 +204,11 @@ def spam(request):
for reason in spam.reasons():
ids = spam.redis.smembers(reason)
key = reason.split(':')[-1]
- buckets[key] = (Review.objects.no_cache().filter(id__in=ids)
- .select_related('addon'))
+ buckets[key] = Review.objects.no_cache().filter(id__in=ids)
+ reviews = dict((review.addon_id, review) for bucket in buckets.values()
+ for review in bucket)
+ for addon in Addon.objects.no_cache().filter(id__in=reviews):
+ reviews[addon.id].addon = addon
return jingo.render(request, 'reviews/spam.html',
dict(buckets=buckets,
review_perms=dict(is_admin=True)))